Octavia CLI uses Basic Auth #17982
Merged
Octavia CLI uses Basic Auth #17982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
commented
Oct 14, 2022
evantahler
changed the title
evantahler
changed the title
evantahler
commented
Oct 14, 2022
alafanechere
requested changes
Oct 17, 2022
sherifnada
approved these changes
Oct 17, 2022
| try: | ||
| assert isinstance(self.name, str) and self.name |
There was a problem hiding this comment.
how come the isinstance check was removedf?
There was a problem hiding this comment.
because above we forced everything to be a string.... so it's a string. This was needed to get around some test/mock issues. Logically, what we cared about anyway was the string's length... so let's check that specifically.
Comment on lines
26
to
30
| self.name = str(self.name) | ||
| self.value = str(self.value) | ||
| try: | ||
| assert isinstance(self.name, str) and self.name | ||
| assert isinstance(self.value, str) and self.value | ||
| assert len(self.name) > 0 | ||
| assert len(self.value) > 0 |
There was a problem hiding this comment.
My concern with this is that most python types can be casted to string without error.
e.g passing a dict as name or value will result in a non-empty casted string...
alafanechere
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
The problem was that in test_get_api_client the airbyte_api_client is patched to a mock object, its attributes and calls to its methods return Mock objects: Configuration is a mock, calling Configuration.get_basic_auth_token returns a Mock too. So when calling ApiHttpHeader("Authorization", basic_auth_token) the basic auth token is a mock and its failing __post_init__.
The solution to this testing problem is to patch the return_value of get_basic_auth_token to return a string.
This is what I did in 4ad020f
7 tasks
evantahler
added a commit
that referenced
this pull request
Oct 19, 2022
* Use Nginx + Basic Auth to secure OSS Airbyte * use local passwords * Use gradle builds * K8s setup and source values from ENV * note about disabling * add back defaults * custom 401 page * update http message * update docs * remove kube files * additional doc updates * Add a test suite * fix failure exit codes * doc updates * Add docs * bump to re-test * add more sleep in tests for CI * better sleep in test * Update docs/operator-guides/security.md Co-authored-by: Davin Chia <davinchia@gmail.com> * PR updates * test comment * change test host on CI * update tests and nginx to boot without backend * proxy updates for docker DNS * simpler test for uptime * acceptance test skips PWs * remove resolver madness * fixup tests * more proxy_pass revert * update acceptance test exit codes * relax test expectations * add temporal mount back for testing * Update docs/operator-guides/security.md Co-authored-by: swyx <shawnthe1@gmail.com> * Update airbyte-proxy/401.html Co-authored-by: swyx <shawnthe1@gmail.com> * more doc updates * Octavia CLI uses Basic Auth (#17982) * [WIP] Octavia CLI uses Basic Auth * readme * augustin: add basic auth headers to clien * augustin: add basic auth headers to client * tests passing * lint * docs * Move monkey patch to test * coerce headers into strings * monkey patch get_basic_auth_token Co-authored-by: alafanechere <augustin.lafanechere@gmail.com> * fix launch permissions * Keep worker port internal * more readme Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: swyx <shawnthe1@gmail.com> Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Use Nginx + Basic Auth to secure OSS Airbyte * use local passwords * Use gradle builds * K8s setup and source values from ENV * note about disabling * add back defaults * custom 401 page * update http message * update docs * remove kube files * additional doc updates * Add a test suite * fix failure exit codes * doc updates * Add docs * bump to re-test * add more sleep in tests for CI * better sleep in test * Update docs/operator-guides/security.md Co-authored-by: Davin Chia <davinchia@gmail.com> * PR updates * test comment * change test host on CI * update tests and nginx to boot without backend * proxy updates for docker DNS * simpler test for uptime * acceptance test skips PWs * remove resolver madness * fixup tests * more proxy_pass revert * update acceptance test exit codes * relax test expectations * add temporal mount back for testing * Update docs/operator-guides/security.md Co-authored-by: swyx <shawnthe1@gmail.com> * Update airbyte-proxy/401.html Co-authored-by: swyx <shawnthe1@gmail.com> * more doc updates * Octavia CLI uses Basic Auth (airbytehq#17982) * [WIP] Octavia CLI uses Basic Auth * readme * augustin: add basic auth headers to clien * augustin: add basic auth headers to client * tests passing * lint * docs * Move monkey patch to test * coerce headers into strings * monkey patch get_basic_auth_token Co-authored-by: alafanechere <augustin.lafanechere@gmail.com> * fix launch permissions * Keep worker port internal * more readme Co-authored-by: Davin Chia <davinchia@gmail.com> Co-authored-by: swyx <shawnthe1@gmail.com> Co-authored-by: alafanechere <augustin.lafanechere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17971
This PR (merged into #17694, not
master) Updates the Octavia CLI to use HTTP Basic Auth by default. Without this PR, the CLI couldn't connect to any server which was using Basic Auth.