🎉 New Source: Vitally [low-code cdk] #18545

elliottrabac · 2022-10-27T13:53:17Z

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

Hacktoberfest: airbytehq/connector-contest#194

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

harshithmullapudi · 2022-10-27T15:01:04Z

Hey hi thanks a lot for the contribution. Do let us know when you are ready with the PR we can review it.

elliottrabac · 2022-10-27T18:10:58Z

Hey hi thanks a lot for the contribution. Do let us know when you are ready with the PR we can review it.

Sure, should be good soon.

elliottrabac · 2022-10-31T00:59:46Z

@harshithmullapudi ✅

marcosmarxm · 2022-10-31T20:07:39Z

@elliottrabac would be possible to share with me a test account credentials in Slack?

marcosmarxm

Thanks for the contribution, a small comment and it is ready to go 🚢

marcosmarxm · 2022-10-31T20:11:26Z

airbyte-integrations/connectors/source-vitally/source_vitally/vitally.yaml

+  accounts_stream:
+    $ref: "*ref(definitions.base_stream)"
+    $options:
+      name: "accounts"
+      primary_key: "id"
+      path: "/accounts"
+    retriever:
+      $ref: "*ref(definitions.base_stream.retriever)"
+      requester:
+        $ref: "*ref(definitions.requester)"
+        request_options_provider:
+          request_parameters:
+            status: "{{ config['status'] }}"


This is a stream needs a special request parameter and the only one not tested. Can you try to add data to this stream?

My bad, I already have data in this stream.

Unfortunately, I don't have any test account here as well and no free trial is available :/

Let me record a video to showcase the output.

Acceptance test:

Check:

Read w/ status = churned:

Read w/ status = active:

Read w/ status = activeOrChurned:

marcosmarxm

Thanks @elliottrabac I'll publish later this week.

marcosmarxm · 2022-11-04T08:35:37Z

Hello! Your PR is approved but didn't have the time to publish and merge it this week. As you can check in Chris' comment all PRs submitted before 2-nov are eligible to win the prize. I'll be out of the office on Friday and return Monday to start publishing your contribution. Any question you can send a message in #hacktoberfest-2022 channel in Airbyte's Slack.

Have a good weekend and thank you for this amazing contribution for Hacktoberfest 🎉

marcosmarxm · 2022-11-13T23:52:07Z

/publish connector=connectors/source-vitally run-tests=false

🕑 Publishing the following connectors:
connectors/source-vitally
https://github.com/airbytehq/airbyte/actions/runs/3457461796

Connector	Did it publish?	Were definitions generated?
connectors/source-vitally	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* create source boilerplate * add account filter * add enum list * add documentation * edit doc url * add organizations stream * update PR number * update tests * add vitally to source def * auto-bump connector version Co-authored-by: marcosmarxm <marcosmarxm@gmail.com> Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

elliottrabac added 4 commits October 27, 2022 07:19

create source boilerplate

0f7a774

add account filter

965ba8d

add enum list

4a51cbe

add documentation

d95d99f

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 27, 2022

Merge branch 'master' into elliot/new-vitally-connector

aa5a74c

octavia-squidington-iv added community connectors/source/vitally labels Oct 27, 2022

marcosmarxm added the hacktober label Oct 27, 2022

elliottrabac and others added 6 commits October 28, 2022 07:24

Merge branch 'master' into elliot/new-vitally-connector

f8d2283

Merge branch 'master' into elliot/new-vitally-connector

e179575

edit doc url

05c3380

add organizations stream

0718dad

update PR number

f4a3339

Merge branch 'master' into elliot/new-vitally-connector

8ce8622

elliottrabac marked this pull request as ready for review October 31, 2022 00:59

octavia-squidington-iv added the bounty label Oct 31, 2022

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

elliottrabac and others added 3 commits November 1, 2022 18:50

Merge branch 'master' into elliot/new-vitally-connector

c555df9

update tests

8d108cc

Merge branch 'master' into elliot/new-vitally-connector

ef093a2

elliottrabac requested a review from marcosmarxm November 1, 2022 18:32

marcosmarxm approved these changes Nov 2, 2022

View reviewed changes

Merge branch 'master' into elliot/new-vitally-connector

a0f7f73

elliottrabac and others added 4 commits November 8, 2022 14:35

Merge branch 'master' into elliot/new-vitally-connector

db03c3b

Merge branch 'master' into elliot/new-vitally-connector

3fac11a

add vitally to source def

ee31760

Merge branch 'master' into elliot/new-vitally-connector

2bb23fa

marcosmarxm approved these changes Nov 13, 2022

View reviewed changes

auto-bump connector version

ecbaa7a

marcosmarxm merged commit b5fd338 into airbytehq:master Nov 14, 2022

RealChrisSean added the low-code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

marcosmarxm changed the title ~~🎉 New Source: Vitally~~ 🎉 New Source: Vitally [low-code cdk] Nov 18, 2022

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Vitally [low-code cdk] #18545

🎉 New Source: Vitally [low-code cdk] #18545

elliottrabac commented Oct 27, 2022 •

edited by RealChrisSean

Loading

harshithmullapudi commented Oct 27, 2022

elliottrabac commented Oct 27, 2022

elliottrabac commented Oct 31, 2022

marcosmarxm commented Oct 31, 2022

marcosmarxm left a comment

marcosmarxm Oct 31, 2022

elliottrabac Nov 1, 2022

elliottrabac Nov 1, 2022

marcosmarxm left a comment

marcosmarxm commented Nov 4, 2022 •

edited

Loading

marcosmarxm commented Nov 13, 2022 •

edited by github-actions bot

Loading

🎉 New Source: Vitally [low-code cdk] #18545

🎉 New Source: Vitally [low-code cdk] #18545

Conversation

elliottrabac commented Oct 27, 2022 • edited by RealChrisSean Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

harshithmullapudi commented Oct 27, 2022

elliottrabac commented Oct 27, 2022

elliottrabac commented Oct 31, 2022

marcosmarxm commented Oct 31, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm Oct 31, 2022

Choose a reason for hiding this comment

elliottrabac Nov 1, 2022

Choose a reason for hiding this comment

elliottrabac Nov 1, 2022

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 4, 2022 • edited Loading

marcosmarxm commented Nov 13, 2022 • edited by github-actions bot Loading

elliottrabac commented Oct 27, 2022 •

edited by RealChrisSean

Loading

marcosmarxm commented Nov 4, 2022 •

edited

Loading

marcosmarxm commented Nov 13, 2022 •

edited by github-actions bot

Loading