🎉 New Source - Intruder [low-code cdk] #18668

haithem-souala · 2022-10-30T19:11:47Z

What

A new source connector using low-code cdk.

How

https://developers.intruder.io/

Streams

Issues
Occurrences issue
Targets
Scans

🚨 User Impact 🚨

N/A

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

marcosmarxm

Hello @haithem-souala, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

marcosmarxm

One comment, pagination is mandatory for this connector. Thanks for the submission @haithem-souala

airbyte-integrations/connectors/source-intruder/source_intruder/intruder.yaml

…yte into connector/intruder

marcosmarxm · 2022-11-02T23:15:17Z

/test connector=connectors/source-intruder

🕑 connectors/source-intruder https://github.com/airbytehq/airbyte/actions/runs/3381813264
✅ connectors/source-intruder https://github.com/airbytehq/airbyte/actions/runs/3381813264
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       133      3    98%   87, 93, 230
	 source_acceptance_test/conftest.py                     196     97    51%   35, 41-43, 48, 54, 60, 66, 72-74, 80-95, 100, 105-107, 113-115, 121-122, 127-128, 133, 139, 148-157, 163-168, 232, 238, 244-250, 258-263, 271-284, 289-295, 302-313, 320-336
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              329    106    68%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 377-379, 382, 447-455, 484-485, 491, 494, 530-540, 553-578
	 source_acceptance_test/tests/test_incremental.py       145     20    86%   21-23, 29-31, 36-43, 48-61, 224
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     10    87%   15-16, 24-30, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/config_migration.py        23     23     0%   5-37
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1479    376    75%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
======================== 24 passed, 3 skipped in 51.24s ========================

marcosmarxm

Thanks @haithem-souala I'll publish later this week.

marcosmarxm · 2022-11-04T08:35:18Z

Hello! Your PR is approved but didn't have the time to publish and merge it this week. As you can check in Chris' comment all PRs submitted before 2-nov are eligible to win the prize. I'll be out of the office on Friday and return Monday to start publishing your contribution. Any question you can send a message in #hacktoberfest-2022 channel in Airbyte's Slack.

Have a good weekend and thank you for this amazing contribution for Hacktoberfest 🎉

marcosmarxm

thanks @haithem-souala

marcosmarxm · 2022-11-14T00:02:20Z

/publish connector=connectors/source-intruder

🕑 Publishing the following connectors:
connectors/source-intruder
https://github.com/airbytehq/airbyte/actions/runs/3457492897

Connector	Did it publish?	Were definitions generated?
connectors/source-intruder	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

marcosmarxm · 2022-11-14T00:31:26Z

/publish connector=connectors/source-intruder run-tests=false

🕑 Publishing the following connectors:
connectors/source-intruder
https://github.com/airbytehq/airbyte/actions/runs/3457623232

Connector	Did it publish?	Were definitions generated?
connectors/source-intruder	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* initial commit * fix schema * lint * add docs * add pagination * add pagination * add intruder to source def * readd ip2whois * add intruder to source def Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>

haithem-souala added 3 commits October 30, 2022 20:03

initial commit

b7c7353

fix schema

8bf0d42

lint

e67c879

github-actions bot added the area/connectors Connector related issues label Oct 30, 2022

octavia-squidington-iv added bounty community connectors/source/intruder labels Oct 30, 2022

add docs

5deabfb

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 30, 2022

haithem-souala mentioned this pull request Oct 30, 2022

New Source - Intruder airbytehq/connector-contest#234

Closed

marcosmarxm added the hacktober label Oct 30, 2022

marcosmarxm requested changes Oct 31, 2022

View reviewed changes

haithem-souala requested a review from marcosmarxm October 31, 2022 12:36

marcosmarxm changed the title ~~🎉 New Source - Intruder~~ 🎉 New Source - Intruder [low-code cdk] Oct 31, 2022

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

airbyte-integrations/connectors/source-intruder/source_intruder/intruder.yaml Outdated Show resolved Hide resolved

haithem-souala added 4 commits November 2, 2022 14:30

add pagination

6de7f38

Merge branch 'airbytehq:master' into connector/intruder

fec9e18

Merge branch 'connector/intruder' of github.com:airbyte-intruder/airb…

17bbe9c

…yte into connector/intruder

add pagination

eaa64f9

haithem-souala requested a review from marcosmarxm November 2, 2022 13:34

marcosmarxm approved these changes Nov 2, 2022

View reviewed changes

marcosmarxm added 3 commits November 13, 2022 20:59

add intruder to source def

415f294

Merge branch 'master' into connector/intruder

eabd6ba

readd ip2whois

2f97528

marcosmarxm approved these changes Nov 14, 2022

View reviewed changes

add intruder to source def

aef8500

marcosmarxm approved these changes Nov 14, 2022

View reviewed changes

marcosmarxm merged commit 30d2621 into airbytehq:master Nov 14, 2022

RealChrisSean added the low-code label Nov 15, 2022

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

sajarin added internal and removed bounty labels Dec 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source - Intruder [low-code cdk] #18668

🎉 New Source - Intruder [low-code cdk] #18668

haithem-souala commented Oct 30, 2022

marcosmarxm left a comment

marcosmarxm left a comment

marcosmarxm commented Nov 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm left a comment

marcosmarxm commented Nov 4, 2022 •

edited

Loading

marcosmarxm left a comment

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

🎉 New Source - Intruder [low-code cdk] #18668

🎉 New Source - Intruder [low-code cdk] #18668

Conversation

haithem-souala commented Oct 30, 2022

What

How

Streams

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 2, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 4, 2022 • edited Loading

marcosmarxm left a comment

Choose a reason for hiding this comment

marcosmarxm commented Nov 14, 2022 • edited by github-actions bot Loading

marcosmarxm commented Nov 14, 2022 • edited by github-actions bot Loading

marcosmarxm commented Nov 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 4, 2022 •

edited

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 14, 2022 •

edited by github-actions bot

Loading