Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bmoric/extract workspace api #18996

Merged
merged 16 commits into from
Nov 8, 2022
Merged

Bmoric/extract workspace api #18996

merged 16 commits into from
Nov 8, 2022

Conversation

benmoriceau
Copy link
Contributor

What

In order to be prepared for a smoother migration to Micronaut for the server, an effort must be made to break the ConfigurationApi into multiple classes. This PR is the first one of a series of PR to come.

How

Extract the WorkspaceApi into its own class

Recommended reading order

No specific order

@github-actions github-actions bot added area/platform issues related to the platform area/server labels Nov 4, 2022
@benmoriceau benmoriceau changed the base branch from master to bmoric/extract-state-api November 4, 2022 22:19
@benmoriceau benmoriceau changed the base branch from bmoric/extract-state-api to bmoric/extract-webbackend-api November 4, 2022 22:19
Base automatically changed from bmoric/extract-webbackend-api to master November 8, 2022 16:42
@benmoriceau benmoriceau requested a review from a team as a code owner November 8, 2022 17:19
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector version
  • Add changelog
  • Publish the new version

⚠ Sources (30)

Connector Version Changelog Publish
source-alloydb 1.0.17
source-alloydb-strict-encrypt 1.0.17
(not in seed)
source-bigquery 0.2.3
source-clickhouse 0.1.14
source-clickhouse-strict-encrypt 0.1.14
(not in seed)
source-cockroachdb 0.1.18
source-cockroachdb-strict-encrypt 0.1.18
(not in seed)
source-db2 0.1.16
source-db2-strict-encrypt 0.1.16
(not in seed)
source-e2e-test 2.1.3
source-e2e-test-cloud 2.1.1
(doc not found)

(not in seed)
source-elasticsearch 0.1.0
source-jdbc 0.3.5
(doc not found)

(not in seed)
source-kafka 0.2.2
source-mongodb-strict-encrypt 0.1.19
(doc not found)

(not in seed)
source-mongodb-v2 0.1.19
source-mssql 0.4.25
source-mssql-strict-encrypt 0.4.25
(not in seed)
source-mysql 1.0.11
source-mysql-strict-encrypt 1.0.11
(not in seed)
source-oracle 0.3.21
source-oracle-strict-encrypt 0.3.21
(not in seed)
source-postgres 1.0.22
source-postgres-strict-encrypt 1.0.22
(not in seed)
source-redshift 0.3.15
source-relational-db 0.3.1
(doc not found)

(not in seed)
source-scaffold-java-jdbc 0.1.0
(doc not found)

(not in seed)
source-sftp 0.1.2
source-snowflake 0.1.24
source-tidb 0.2.1
  • See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (42)

Connector Version Changelog Publish
destination-azure-blob-storage 0.1.6
(doc not found)
destination-bigquery 1.2.5
destination-bigquery-denormalized 1.2.5
(doc not found)
destination-cassandra 0.1.4
(changelog missing)
destination-clickhouse 0.2.0
destination-clickhouse-strict-encrypt 0.2.0
(not in seed)
destination-csv 0.2.10
(doc not found)
destination-databricks 0.3.1
destination-dev-null 0.2.7
(doc not found)

(not in seed)
destination-dynamodb 0.1.7
destination-e2e-test 0.2.4
destination-elasticsearch 0.1.6
destination-elasticsearch-strict-encrypt 0.1.6
(not in seed)
destination-gcs 0.2.12
destination-jdbc 0.3.14
(doc not found)

(not in seed)
destination-kafka 0.1.10
(changelog missing)
destination-keen 0.2.4
(changelog missing)
destination-kinesis 0.1.5
(changelog missing)
destination-local-json 0.2.11
destination-mariadb-columnstore 0.1.7
destination-mongodb 0.1.8
destination-mongodb-strict-encrypt 0.1.8
(not in seed)
destination-mqtt 0.1.3
destination-mssql 0.1.22
destination-mssql-strict-encrypt 0.1.22
(not in seed)
destination-mysql 0.1.20
destination-mysql-strict-encrypt 0.1.21
(mismatch: 0.1.20)

(not in seed)
destination-oracle 0.1.19
destination-oracle-strict-encrypt 0.1.19
(not in seed)
destination-postgres 0.3.26
destination-postgres-strict-encrypt 0.3.26
(not in seed)
destination-pubsub 0.1.6
(changelog missing)
destination-pulsar 0.1.3
(changelog missing)
destination-r2 0.1.0
destination-redis 0.1.4
destination-redshift 0.3.51
destination-rockset 0.1.4
(changelog missing)
destination-s3 0.3.17
destination-scylla 0.1.3
destination-snowflake 0.4.38
destination-tidb 0.1.0
destination-yugabytedb 0.1.0
  • See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@benmoriceau benmoriceau temporarily deployed to more-secrets November 8, 2022 17:21 Inactive
@benmoriceau benmoriceau requested review from alovew, colesnodgrass, gosusnp and jdpgrailsdev and removed request for a team November 8, 2022 17:56
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau merged commit 1cdf1ba into master Nov 8, 2022
@benmoriceau benmoriceau deleted the bmoric/extract-workspace-api branch November 8, 2022 18:15
akashkulk pushed a commit that referenced this pull request Dec 2, 2022
* Extract Operation API

* Extract scheduler API

* Format

* extract source api

* Extract source definition api

* Add path

* Extract State API

* extract webbackend api

* extract webbackend api

* extract workspace api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants