Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tests for destination connectors #19007

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Fixed tests for destination connectors #19007

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4185160
Fixed tests for destination connectors
etsybaev Nov 5, 2022
0a015c9
Fixed tests for destination connectors
etsybaev Nov 5, 2022
f016195
Fixed tests for destination connectors
etsybaev Nov 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ...main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,8 +1217,7 @@ protected void runSyncAndVerifyStateOutput(final JsonNode config,
final List<AirbyteMessage> destinationOutput = runSync(config, messages, catalog,
runNormalization);

Collections.reverse(messages);
final AirbyteMessage expectedStateMessage = messages
final AirbyteMessage expectedStateMessage = reversed(messages)
.stream()
.filter(m -> m.getType() == Type.STATE)
.findFirst()
Expand All @@ -1238,6 +1237,20 @@ protected void runSyncAndVerifyStateOutput(final JsonNode config,
assertEquals(expectedStateMessage, actualStateMessage);
}

/**
* Reverses a list by creating a new list with the same elements of the input list and then
* reversing it. The input list will not be altered.
*
* @param list to reverse
* @param <T> type
* @return new list with elements of original reversed.
*/
public static <T> List<T> reversed(final List<T> list) {
final ArrayList<T> reversed = new ArrayList<>(list);
Collections.reverse(reversed);
return reversed;
}

private List<AirbyteMessage> runSync(
final JsonNode config,
final List<AirbyteMessage> messages,
Expand Down