Add improvements to "Building a connector the hard way" #19093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/documentation
erohmensing
commented
Nov 7, 2022
docs/connector-development/tutorials/build-a-connector-the-hard-way.md
Outdated
Show resolved
Hide resolved
evantahler
approved these changes
Nov 8, 2022
airbyte-integrations/connectors/source-stock-ticker-api-tutorial/source.py
Show resolved
Hide resolved
docs/connector-development/tutorials/build-a-connector-the-hard-way.md
Outdated
Show resolved
Hide resolved
docs/connector-development/tutorials/build-a-connector-the-hard-way.md
Outdated
Show resolved
Hide resolved
This reverts commit 40b2d98.
akashkulk
pushed a commit
that referenced
this pull request
Dec 2, 2022
* Add improvements to "Building a connector the hard way" * add log_error() formatting to pass SAT tests * Update to new version of acceptance-test-config.yml * Edit tutorial directory to match tutorial * Change permissions on acceptance-test-docker.sh This reverts commit 40b2d98.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Small improvements based on my experience following Building a source connector: the hard way