Add dependencies to docker-compose #19321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies-to-docker-compose
This reverts commit c3b28c9.
…ndencies-to-docker-compose
sophia-wiley
approved these changes
Jan 11, 2023
gosusnp
deleted the
revert-19306-revert-19257-gosusnp/add-dependencies-to-docker-compose
branch
jbfbell
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Revert "Revert "Add dependencies to docker-compose (#19257)" (#19306)" This reverts commit b16f28f. * Bump docker-compose version * test * Revert "test" This reverts commit c3b28c9. * Bump docker compose version to 3.8 * test * test * Use a newer docker for platform build * test * Use docker compose v2 * Update docker for frontend e2e * Use docker compose v2 for e2e tests * Update tools to use docker compose v2 * Update more docker compose references to v2 * Update docker compose usage in docs * Update deploying airbyte docs * Fix permission * Case insensistive check * Add extra mention for docker compose in upgrading airbyte * Improve upgrade docker note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The bootloader should run before the other applications.
If the bootloader fails, it is likely a sign that the setup failed and that we may have an unexpected state that is not safe for the other applications.
We should define the bootloader as a dependencies for the applications that depends on it.
Reverts #19306
How
Use conditional depends_on.
airbyte-bootloaderterminating successfullyRelease Notes
Starting from version 0.40.27, Airbyte will require docker compose v2.
It means that docker-compose v2 will be required in order to upgrade any Airbyte instance running with docker.
Docker compose v2 should be available by default with most recent docker desktop installations. For linux environments, please refer to the docker documentation https://docs.docker.com/compose/install/linux/.
Note that docker-compose v2 should act as a drop-in replacement for most docker-compose usage.
Following this upgrade, Airbyte will have an explicit check that prevents the application from starting in case of conflicting configuration that would prevent active connections from running properly.
In case of errors upon upgrade, please refer to the troubleshooting documentation https://docs.airbyte.com/troubleshooting/on-deploying