Source Freshdesk: do not call response.json() inside should_retry

[davydov-d]

What

https://github.com/airbytehq/oncall/issues/1006

How

Do not call response.json() inside should_retry since the response body may be empty

[davydov-d]

/test connector=connectors/source-freshdesk

🕑 connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3444805305
✅ connectors/source-freshdesk https://github.com/airbytehq/airbyte/actions/runs/3444805305
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_freshdesk/source.py        31      0   100%
source_freshdesk/__init__.py       2      0   100%
source_freshdesk/streams.py      221      3    99%
source_freshdesk/utils.py         20      1    95%
--------------------------------------------------
TOTAL                            274      4    99%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    349    78%

Build Passed

Test summary info:

All Passed

[davydov-d]

/publish connector=connectors/source-freshdesk

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

[davydov-d]

/publish connector=connectors/source-freshdesk

🕑 Publishing the following connectors:
connectors/source-freshdesk
https://github.com/airbytehq/airbyte/actions/runs/3445459594

Connector	Did it publish?	Were definitions generated?
connectors/source-freshdesk	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️