馃獰馃И馃悰 Fix redirection in signup source selector experiment #19382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
edmundito
reviewed
Nov 14, 2022
Comment on lines
+31
to
+35
| {...(isSignupSourceSelectorExperiment && | ||
| sourceDefinitionId && { | ||
| state: { sourceDefinitionId }, | ||
| to: `/${RoutePaths.Workspaces}/${workspaces[0].workspaceId}/${RoutePaths.Connections}/${RoutePaths.ConnectionNew}`, | ||
| })} |
There was a problem hiding this comment.
Maybe this could be cleaned up to make it easier to follow the logic? A better way might be to set up the props before the render. For example:
let navigateProps: NavigateProps = { replace: true }
if (somecondition) {
navigateProps = {
...navigateProps,
state: { sourceDefintionId },
to: `...`
}
} else {
navigateProps.to = `...`
}
return <Navigate {...navigateProps} />
There was a problem hiding this comment.
The reason we keep it separate is that the experiments are meant to be removed completely potentially when they are not successful, so the code is tried to be highlighted separately. Leti, treat this as a 馃Ч that needs to be cleaned up if we keep this.
timroes
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://www.loom.com/share/fabca04e7b024e16b0f714b22bef3f52
What
Fixed a bug introduced in signup source selector experiment where the user was being redirected every time to /connections/new-connection