🪟 🐛 Hotfix getValues failures in connector form #19400
Conversation
octavia-squidington-iv
added
area/platform
| // We still see cases where calling `getValues` which will eventually use the yupSchema.cast method | ||
| // crashes based on the passed in values. To temporarily make sure we're not crashing the form, we're | ||
| // falling back to `values` in case the cast fails. This is a temporary patch, and we need to investigate | ||
| // all the failures happening here properly. |
There was a problem hiding this comment.
To temporarily make sure we're not crashing the form, we're falling back to
valuesin case the cast fails.
What are the consequences of falling back to values in this case? Does this just mean that default values will not be inserted, or are there any others?
There was a problem hiding this comment.
afaik it should only cause the default values to not be present, and just have the Formik values "as it". Ideally we still figure out quick enough what cases might fail here (since the weird S3 spec might not the only one) and try to fix them properly, but that way we have at least a chance it's still working "largely" (given that even without the default value, we saw most OAuth connectors working).
There was a problem hiding this comment.
Changes LGTM, as we discussed over zoom. I tested locally the S3 destination and the behavior looked like it was working as it did over zoom.
I tried out other several other connectors as well, and they all seemed to work as expected from what I could tell. So I think this is fine to merge and deploy in the morning!
* Hotfix getValues failures in connector form * Fix jest tests * Fix jest tests * Show errors somewhat properly * Fix jest tests
What
Hotfix for https://github.com/airbytehq/oncall/issues/1050
Makes sure we're not failing the ConnectorForm in case the
getValuescast fails due to some issues (we seem to have some issues where the values are not cleared out properly and such clash with the validation schema while casting).