New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a variable to control airbyte-proxy timeout #19493
Added a variable to control airbyte-proxy timeout #19493
Conversation
Some connecters like Zuora might take longer than 300 seconds. I'd suggest to increase it to 600 seconds. |
I think it should be a variable that people can configure in their .env. I will make the necessary change |
That's even better. Thank you @marcelopio 聽馃檹馃徏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sad that we need this change (because we have connectors which take over a minute to return their schema), but given that, this is a great change!
Co-authored-by: Evan Tahler <evantahler@gmail.com>
@evantahler @natalyjazzviolin Do we need anything more to get this merged? Thx! |
I'm looking forward to it 馃槉 |
We are on a Thanksgiving Code Freeze (US holiday), but we will look at merging this in December (馃憤 from me @natalyjazzviolin) |
Hello 馃憢, first thank you for this amazing contribution. We really appreciate the effort you've made to improve the project. If you have any questions feel free to send me a message in Slack! |
@marcelopio thanks for resolving the conflicts! I'm running all CI/CD checks here: #19831 as I am not able to run them here. Once those pass we should be good to go! |
Hi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcelopio need to correct the file permission
Tested in #20361 it is working. |
What
Fixes #19290
How
Adding a default timeout on the proxy template files of airbyte
Recommended reading order
x.java
y.python
馃毃 User Impact 馃毃
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 馃毃馃毃 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.