Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃獰 馃Ч Removes old statuses enum #19599

Merged
merged 1 commit into from
Nov 18, 2022
Merged

馃獰 馃Ч Removes old statuses enum #19599

merged 1 commit into from
Nov 18, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Nov 18, 2022

What

Removes an old shared Status enum that should no longer be used, but instead the enums from the API generated types should be used.

@timroes timroes requested a review from a team as a code owner November 18, 2022 14:58
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 18, 2022
krishnaglick
krishnaglick approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, LGTM if build is green

@timroes timroes merged commit a017133 into master Nov 18, 2022
@timroes timroes deleted the tim/remove-statuses branch November 18, 2022 15:33
@github-actions github-actions bot mentioned this pull request Nov 18, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timroes @krishnaglick @octavia-squidington-iv