Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find_non_rate_limited_PAT #19736

Merged
merged 2 commits into from
Nov 23, 2022
Merged

find_non_rate_limited_PAT #19736

merged 2 commits into from
Nov 23, 2022

Conversation

git-phu
Copy link
Contributor

@git-phu git-phu commented Nov 23, 2022

What

the find_non_rate_limited_PAT script returns the PAT as an environment variable, so let's use it.

echo "PAT=$personal_access_token" >> $GITHUB_ENV

How

Environment variables cannot be propagated across jobs, so just call the find_non_rate_limited_PAT script whenever we need a PAT

related: https://github.com/airbytehq/airbyte-cloud/issues/3587

@git-phu git-phu marked this pull request as ready for review November 23, 2022 00:12
@git-phu git-phu temporarily deployed to more-secrets November 23, 2022 00:32 Inactive
@git-phu git-phu temporarily deployed to more-secrets November 23, 2022 00:32 Inactive
@git-phu git-phu merged commit 0c73b70 into master Nov 23, 2022
@git-phu git-phu deleted the peter/PATs branch November 23, 2022 00:33
SofiiaZaitseva pushed a commit that referenced this pull request Nov 24, 2022
* find_non_rate_limited_PAT

* checkout repo to find pat
letiescanciano added a commit that referenced this pull request Nov 28, 2022
* master: (74 commits)
  Fix support icon in sidebar
  fix: add BuildPulse report for helm ac tests (#19785)
  fix: yaml syntax (#19775)
  🪟 🐛 Fix custom connection creation endpoint (#19702)
  Source facebook marketing: check "breakdowns" combinations (#19645)
  fix typo: notify instead of sync (#19737)
  find_non_rate_limited_PAT (#19736)
  Source Google Ads: fix schema for "campaigns" stream (#19700)
  🎉 Source Asana: migrate to new SAT, added base HTTP errors handling (#19561)
  fix order not to randomly fail backward compatibility check (#19377)
  Bump helm chart version reference to 0.42.0 (#19706)
  fix: add extraEnv block (#19703)
  Bump Airbyte version from 0.40.21 to 0.40.22 (#19687)
  Bump helm chart version reference to 0.41.3 (#19685)
  Add connector builder server to airbyte proxy, kube overlays, and helm charts (#19554)
  dbt Cloud integration doc (#19619)
  🪟 🎉 Display service token validation errors in the UI (#19578)
  17644 Update Destination data type test to use the new data types (#19281)
  Docs: fix broken connector builder UI docs links (#19631)
  Bump Airbyte version from 0.40.20 to 0.40.21 (#19634)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants