Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Delighted: migrate to lowcode + certify to beta #19822

Merged
merged 7 commits into from
Dec 9, 2022

Conversation

davydov-d
Copy link
Collaborator

What

#18711

How

  1. Migrate to lowcode
  2. Certify to Beta

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/delighted labels Nov 28, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 28, 2022

/test connector=connectors/source-delighted

🕑 connectors/source-delighted https://github.com/airbytehq/airbyte/actions/runs/3564661751
❌ connectors/source-delighted https://github.com/airbytehq/airbyte/actions/runs/3564661751
🐛 https://gradle.com/s/kurinmqgzbj7q

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_full_refresh.py::TestFullRefresh::test_sequential_reads[inputs0]
=================== 1 failed, 30 passed in 276.99s (0:04:36) ===================

@davydov-d davydov-d temporarily deployed to more-secrets November 28, 2022 12:16 Inactive
@davydov-d davydov-d temporarily deployed to more-secrets November 28, 2022 12:16 Inactive
@davydov-d
Copy link
Collaborator Author

blocked by #19712

@davydov-d davydov-d temporarily deployed to more-secrets November 28, 2022 16:31 Inactive
@davydov-d davydov-d temporarily deployed to more-secrets November 28, 2022 16:31 Inactive
@davydov-d
Copy link
Collaborator Author

davydov-d commented Nov 28, 2022

/test connector=connectors/source-delighted

🕑 connectors/source-delighted https://github.com/airbytehq/airbyte/actions/runs/3569446265
✅ connectors/source-delighted https://github.com/airbytehq/airbyte/actions/runs/3569446265
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1563    349    78%

Build Passed

Test summary info:

All Passed

@davydov-d davydov-d temporarily deployed to more-secrets November 28, 2022 23:12 Inactive
@davydov-d davydov-d temporarily deployed to more-secrets November 28, 2022 23:12 Inactive
@davydov-d davydov-d requested review from a team, brianjlai and girarda November 29, 2022 06:55
@girarda girarda requested review from a team and removed request for a team November 29, 2022 07:18
@davydov-d davydov-d temporarily deployed to more-secrets November 30, 2022 19:17 Inactive
@davydov-d davydov-d temporarily deployed to more-secrets November 30, 2022 19:17 Inactive
@lazebnyi lazebnyi changed the title Source Delighted: migrate to lowcode + certify to beta 🎉Source Delighted: migrate to lowcode + certify to beta Dec 6, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 9, 2022

/publish connector=connectors/source-delighted

🕑 Publishing the following connectors:
connectors/source-delighted
https://github.com/airbytehq/airbyte/actions/runs/3658842330


Connector Did it publish? Were definitions generated?
connectors/source-delighted

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 9, 2022

/publish connector=connectors/source-delighted

🕑 Publishing the following connectors:
connectors/source-delighted
https://github.com/airbytehq/airbyte/actions/runs/3658939228


Connector Did it publish? Were definitions generated?
connectors/source-delighted

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d temporarily deployed to more-secrets December 9, 2022 16:12 — with GitHub Actions Inactive
@davydov-d davydov-d temporarily deployed to more-secrets December 9, 2022 16:12 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 9, 2022 16:39 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 9, 2022 16:39 — with GitHub Actions Inactive
@davydov-d davydov-d merged commit ee54c24 into master Dec 9, 2022
@davydov-d davydov-d deleted the ddavydov/#18711-source-delighted-to-beta-yaml branch December 9, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/delighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants