Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook Marketing: support insights streams via async queries #1990

Merged
merged 10 commits into from
Feb 15, 2021
Merged

Source Facebook Marketing: support insights streams via async queries #1990

merged 10 commits into from
Feb 15, 2021

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Feb 8, 2021 •
edited
Loading

What

Supports syncing various Ad Insight streams in a batch manner

@sherifnada sherifnada changed the title [WIP] Source Facebook Marketing: readd insights streams and test catalogues Source Facebook Marketing: readd insights streams and test catalogues Feb 12, 2021
@sherifnada sherifnada marked this pull request as ready for review February 12, 2021 18:02
@sherifnada sherifnada changed the title Source Facebook Marketing: readd insights streams and test catalogues Source Facebook Marketing: pull insights in batch jobs Feb 12, 2021
@sherifnada sherifnada changed the title Source Facebook Marketing: pull insights in batch jobs Source Facebook Marketing: support insights streams via async queries Feb 12, 2021
@sherifnada
Copy link
Contributor Author

sherifnada commented Feb 12, 2021 •
edited by github-actions bot
Loading

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/561806475
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/561806475

@sherifnada
Copy link
Contributor Author

sherifnada commented Feb 12, 2021 •
edited by github-actions bot
Loading

/test connector=source-facebook-marketing

🕑 source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/562382922
❌ source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/562382922

@sherifnada sherifnada linked an issue Feb 15, 2021 that may be closed by this pull request
Facebook source with daily ad metrics and breakdowns #1963
Closed
@sherifnada sherifnada mentioned this pull request Feb 15, 2021
Closed
@sherifnada
Copy link
Contributor Author

sherifnada commented Feb 15, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/567740321
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/567740321

@sherifnada
Copy link
Contributor Author

sherifnada commented Feb 15, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/568032691
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/568032691

@sherifnada
Copy link
Contributor Author

Had to make two concessions in testing to pass tests:

  1. Removed ad insights from catalog used in standard tests because ad insights change frequently as FB accumulates them (they're approximations)
  2. Removed ad creatives from standard tests because they have a volatile field in them that frequently change

I added both of them to custom integration tests

@sherifnada sherifnada merged commit 8dc6c7c into master Feb 15, 2021
@sherifnada sherifnada deleted the sherif/add-fb-insights branch February 15, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

@eugene-kulak eugene-kulak Awaiting requested review from eugene-kulak

@jrhizor jrhizor Awaiting requested review from jrhizor

Assignees
No one assigned
Labels
connectors/source/facebook-marketing connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facebook source with daily ad metrics and breakdowns
3 participants
@sherifnada @cgardens @karinakuz