Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Gradle 7.6 #19926

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Update to Gradle 7.6 #19926

merged 4 commits into from
Dec 1, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

How

  • Update the Gradle wrapper to the latest release version
  • Bump the system-stubs dependency to pick up changes for Java 19

Recommended reading order

  1. build.gradle
  2. gradle-wrapper.properties

Tests

  • All tests pass
  • Project builds locally

@jdpgrailsdev jdpgrailsdev requested a review from a team as a code owner November 30, 2022 16:27
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 30, 2022 16:27 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 30, 2022 16:31 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets November 30, 2022 22:04 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 1, 2022 14:36 Inactive
@davinchia
Copy link
Contributor

davinchia commented Dec 1, 2022 •
edited
Loading

huh, didn't you merge this in already?

davinchia
davinchia approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, we are going to have to do some upgrading of the other tooling dependencies to accommodate Java 19. Can do in subsequent PRs.

See https://github.com/airbytehq/airbyte/pull/19810/files.

@jdpgrailsdev
Copy link
Contributor Author

jdpgrailsdev commented Dec 1, 2022 •
edited
Loading

huh, didn't you merge this in already?

No? There was another PR in cloud that bumped it to the same Gradle version. Perhaps that is the confusion.

@jdpgrailsdev jdpgrailsdev merged commit 0f13fa1 into master Dec 1, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/gradle-7.6 branch December 1, 2022 15:45
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Closed
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davinchia davinchia davinchia approved these changes

@git-phu git-phu Awaiting requested review from git-phu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdpgrailsdev @davinchia