Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dark variant to Button #19957

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Added dark variant to Button #19957

merged 1 commit into from
Dec 2, 2022

Conversation

matter-q
Copy link
Contributor

@matter-q matter-q commented Dec 1, 2022 •
edited
Loading

What

Closes #19445

How

Added dark variant to Button component

Figma prototype

Test result

State: default, active, disabled, icon + focus, loading

image

@matter-q matter-q requested a review from a team as a code owner December 1, 2022 00:12
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 1, 2022
@edmundito edmundito requested review from YatsukBogdan1 and krishnaglick and removed request for a team December 1, 2022 17:55
krishnaglick
krishnaglick approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed setting clickable to false does not change the cursor type. Not to be fixed here but do you know if it's got a ticket anywhere?

Edit: nevermind

YatsukBogdan1
YatsukBogdan1 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@YatsukBogdan1 YatsukBogdan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matter-q matter-q merged commit e532d7b into master Dec 2, 2022
@matter-q matter-q deleted the mark/add-dark-variant-to-Button branch December 2, 2022 18:51
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick approved these changes

@YatsukBogdan1 YatsukBogdan1 YatsukBogdan1 approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dark variant to Button
4 participants
@matter-q @krishnaglick @YatsukBogdan1 @octavia-squidington-iv