make our unit tests less brittle and not compare against messages out of our control #20009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjlai
commented
Dec 1, 2022
|
|
||
| assert actual_exception.value.status_code == 400 | ||
| assert actual_exception.value.detail == "Could not perform read with with error: Every message grouping should have at least one request and response" | ||
| assert "Could not perform read with with error" in actual_exception.value.detail |
There was a problem hiding this comment.
we could even do away with checking any error text at all since text is often changing and error code tends to be more important
There was a problem hiding this comment.
+1 to not testing the error message
alovew
approved these changes
Dec 2, 2022
girarda
approved these changes
Dec 2, 2022
brianjlai
deleted the
brian/make_connector_builder_error_tests_less_brittle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We had some tests in the connector builder server that asserted on very specific error messages. Something mightve changed upstream with additional quotes. This is breaking the build.
How
I'm not 100% what changed slightly upstream, but at the end of the day we really shouldn't be having tests that look for specific text and especially when that text is dependent on an external package (in this case
airbyte-cdk). We should just test what is mostly in our control like status code and part of the error text that our server is emitted.