Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪟 🎨 Auto-detect schema changes UI fixes #20070

Merged
merged 3 commits into from
Dec 6, 2022
Merged

🪟 🎨 Auto-detect schema changes UI fixes #20070

merged 3 commits into from
Dec 6, 2022

Conversation

edmundito
Copy link
Contributor

What

Related to #17828

Fixes small issues in the auto-detect schema change UI:

  • Makes "Review changes" button variant dark to match the design
  • Adds matching hover state to source link when there is a breaking or non-breaking change
  • Removes periods from breaking/non-breaking messages

@edmundito edmundito requested a review from a team as a code owner December 5, 2022 15:00
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 5, 2022
teallarson
teallarson approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. Tested changes locally.

@edmundito edmundito merged commit e93f8aa into master Dec 6, 2022
@edmundito edmundito deleted the edmundito/auto-detect-schema-updates branch December 6, 2022 16:15
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teallarson teallarson teallarson approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edmundito @teallarson @octavia-squidington-iv