🪟🐛 Warn on navigating away from unsaved connector form with error #20072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
area/frontend
team/extensibility
area/frontend
lmossman
approved these changes
Dec 5, 2022
| @@ -89,7 +89,7 @@ export interface ConnectorFormProps { | |||
| formId?: string; | |||
| selectedConnectorDefinition?: ConnectorDefinition; | |||
| selectedConnectorDefinitionSpecification?: ConnectorDefinitionSpecification; | |||
| onSubmit: (values: ConnectorFormValues) => Promise<void> | void; | |||
There was a problem hiding this comment.
This looks much cleaner now 🙌
This was referenced Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #18246
When navigating away from an unsaved connector form with an error, the warning is shown.
How
Make sure exceptions are thrown up the promise chain from the actual react-query call to the submit callback so the connector form is not clearing the dirty state of the form change tracker.