Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #20086] fix precommit pyproject-flake8 dependency issue #20087

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Dec 5, 2022

What

This addresses issue airbytehq/airbyte-internal-issues#1165 where an old version of pyproject-flake8 would call a recent version of flake8 that had a breaking change.

How

Update pyproject-flake8 to the most recent

馃毃 User Impact 馃毃

None since pre-commit will see the new version of pyproject-flake8 in the config file and on the next git commit will run the following:

maxime@Maxime-MacBookPro-RM609Q3XML airbyte % git commit -m "test"
[INFO] Initializing environment for https://github.com/csachs/pyproject-flake8.
[INFO] Initializing environment for https://github.com/csachs/pyproject-flake8:mccabe.
[INFO] Installing environment for https://github.com/csachs/pyproject-flake8.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
<logs for the "normal" pre-commit hook will follow>

Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@terencecho
Copy link
Contributor

terencecho commented Dec 6, 2022

My apologies, I accidentally committed this file change along with my very unrelated PR.

If you'd like, we can undo my changes with my new PR: #20114, and then we can merge this PR, which I think will be beneficial in terms of git blame history, since this PR has much more context.

If that sounds like a good plan to you, feel free to approve and merge my PR and then merge this one!

@maxi297 maxi297 merged commit 772a01a into master Dec 6, 2022
@maxi297 maxi297 deleted the issue-20086_fix-pre-commit-version branch December 6, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants