Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing "unknown" reason #20096

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Add missing "unknown" reason #20096

merged 2 commits into from
Dec 5, 2022

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Ensure that all FailureReason values can be mapped to AttemptFailureOrigin

How

  • Add the missing value to AttemptFailureOrigin

Recommended reading order

  1. config.yaml

Relates to #19665.

@octavia-squidington-iv octavia-squidington-iv added area/api Related to the api area/platform issues related to the platform labels Dec 5, 2022
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 5, 2022 20:37 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 5, 2022 20:52 Inactive
@jdpgrailsdev jdpgrailsdev temporarily deployed to more-secrets December 5, 2022 20:53 Inactive
@jdpgrailsdev jdpgrailsdev merged commit 78aa46d into master Dec 5, 2022
@jdpgrailsdev jdpgrailsdev deleted the jonathan/add-missing-reason branch December 5, 2022 21:26
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malikdiarra malikdiarra malikdiarra approved these changes

@benmoriceau benmoriceau benmoriceau approved these changes

Assignees
No one assigned
Labels
area/api Related to the api area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdpgrailsdev @malikdiarra @benmoriceau @octavia-squidington-iv