Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional MySQL integration tests #20119

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Fix additional MySQL integration tests #20119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06ae610
Fix test : attempt 1
akashkulk Dec 6, 2022
fd2cb98
Remove setting cloud
akashkulk Dec 6, 2022
15268ea
Merge branch 'master' into fix_mysql_test
akashkulk Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...te/integrations/io/airbyte/integration_tests/sources/SshKeyMySqlSourceAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,26 @@

package io.airbyte.integrations.io.airbyte.integration_tests.sources;

import io.airbyte.commons.features.EnvVariableFeatureFlags;
import io.airbyte.integrations.standardtest.source.TestDestinationEnv;
import java.nio.file.Path;
import org.junit.jupiter.api.extension.ExtendWith;
import uk.org.webcompere.systemstubs.environment.EnvironmentVariables;
import uk.org.webcompere.systemstubs.jupiter.SystemStub;
import uk.org.webcompere.systemstubs.jupiter.SystemStubsExtension;

@ExtendWith(SystemStubsExtension.class)
public class SshKeyMySqlSourceAcceptanceTest extends AbstractSshMySqlSourceAcceptanceTest {

@SystemStub
private EnvironmentVariables environmentVariables;

@Override
protected void setupEnvironment(final TestDestinationEnv environment) throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: might be better to put this in AbstractSshMySqlSourceAcceptanceTest rather than duplicating into both subclasses

environmentVariables.set(EnvVariableFeatureFlags.USE_STREAM_CAPABLE_STATE, "true");
super.setupEnvironment(environment);
}

@Override
public Path getConfigFilePath() {
return Path.of("secrets/ssh-key-repl-config.json");
Expand Down
16 changes: 16 additions & 0 deletions ...tegrations/io/airbyte/integration_tests/sources/SshPasswordMySqlSourceAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,26 @@

package io.airbyte.integrations.io.airbyte.integration_tests.sources;

import io.airbyte.commons.features.EnvVariableFeatureFlags;
import io.airbyte.integrations.standardtest.source.TestDestinationEnv;
import java.nio.file.Path;
import org.junit.jupiter.api.extension.ExtendWith;
import uk.org.webcompere.systemstubs.environment.EnvironmentVariables;
import uk.org.webcompere.systemstubs.jupiter.SystemStub;
import uk.org.webcompere.systemstubs.jupiter.SystemStubsExtension;

@ExtendWith(SystemStubsExtension.class)
public class SshPasswordMySqlSourceAcceptanceTest extends AbstractSshMySqlSourceAcceptanceTest {

@SystemStub
private EnvironmentVariables environmentVariables;

@Override
protected void setupEnvironment(final TestDestinationEnv environment) throws Exception {
environmentVariables.set(EnvVariableFeatureFlags.USE_STREAM_CAPABLE_STATE, "true");
super.setupEnvironment(environment);
}

@Override
public Path getConfigFilePath() {
return Path.of("secrets/ssh-pwd-repl-config.json");
Expand Down