Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint CDK files #20163

Merged
merged 6 commits into from
Dec 7, 2022
Merged

lint CDK files #20163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f6f9ed
lint CDK files
evantahler Dec 6, 2022
24f6aa9
bump to rebuild file
evantahler Dec 6, 2022
760bec9
format again?
evantahler Dec 6, 2022
595dd7b
remove double line
evantahler Dec 6, 2022
bd5c2ba
fix spacing in template
evantahler Dec 6, 2022
c53f10d
remove trailing space
evantahler Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...thon/airbyte_cdk/sources/declarative/requesters/paginators/strategies/offset_increment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
from typing import Any, List, Mapping, Optional, Union

import requests
from airbyte_cdk.sources.declarative.requesters.paginators.strategies.pagination_strategy import PaginationStrategy
from airbyte_cdk.sources.declarative.interpolation import InterpolatedString
from airbyte_cdk.sources.declarative.requesters.paginators.strategies.pagination_strategy import PaginationStrategy
from airbyte_cdk.sources.declarative.types import Config
from dataclasses_jsonschema import JsonSchemaMixin

Expand Down
1 change: 0 additions & 1 deletion ...-cdk/python/unit_tests/sources/declarative/requesters/paginators/test_offset_increment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import pytest
import requests

from airbyte_cdk.sources.declarative.interpolation import InterpolatedString
from airbyte_cdk.sources.declarative.requesters.paginators.strategies.offset_increment import OffsetIncrement

Expand Down
3 changes: 1 addition & 2 deletions airbyte-integrations/connector-templates/source-java-jdbc/acceptance-test-config.yml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ acceptance_tests:
spec:
tests:
- spec_path: "src/test-integration/resources/expected_spec.json"
config_path: "src/test-integration/resources/dummy_config.json"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a trailing space here that was ruining things :(


config_path: "src/test-integration/resources/dummy_config.json"