Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte-metric: implement recordErrorOnRootSpan in ApmUtils #20286

Merged
merged 17 commits into from Dec 13, 2022
Merged

airbyte-metric: implement recordErrorOnRootSpan in ApmUtils #20286

merged 17 commits into from Dec 13, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Dec 9, 2022 •
edited

What

We want to leverage the Error Tracking panel of Datadog.
To do so, we need to bubble up exceptions to the root span, so datadog considers this a new error.

How

Add recordErrorOnRootSpan method to ApmTraceUtils

Context

I'm using it in https://github.com/airbytehq/airbyte-cloud/pull/3799

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Dec 9, 2022
@alafanechere alafanechere temporarily deployed to more-secrets December 9, 2022 09:50 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 9, 2022 09:51 — with GitHub Actions Inactive
@alafanechere alafanechere marked this pull request as ready for review December 9, 2022 09:57
@alafanechere alafanechere requested a review from a team as a code owner December 9, 2022 11:28
@alafanechere alafanechere temporarily deployed to more-secrets December 9, 2022 11:30 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 9, 2022 11:30 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 9, 2022 12:40 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 9, 2022 12:40 — with GitHub Actions Inactive
@alafanechere alafanechere marked this pull request as draft December 9, 2022 14:52
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 14:38 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 14:39 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 14:57 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 14:58 — with GitHub Actions Inactive
@alafanechere alafanechere changed the title airbyte-server: call addExceptionToTrace in OAuthHandler methods airbyte-server: better track OAuthHandler methods failure in datadog Dec 12, 2022
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 15:27 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 15:28 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 21:38 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 12, 2022 21:38 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 13:06 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 13:07 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 14:02 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 14:02 — with GitHub Actions Inactive
@alafanechere alafanechere force-pushed the augustin/server/oauth-span-exception branch from d78d848 to 378cea7 Compare December 13, 2022 14:28
@octavia-squidington-iv octavia-squidington-iv removed area/platform issues related to the platform area/server labels Dec 13, 2022
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 14:30 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 14:30 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 14:33 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 14:34 — with GitHub Actions Inactive
@alafanechere alafanechere changed the title airbyte-server: better track OAuthHandler methods failure in datadog airbyte-metric: implement recordErrorOnRootSpan in ApmUtils Dec 13, 2022
@alafanechere alafanechere marked this pull request as ready for review December 13, 2022 15:44
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 15:46 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 15:47 — with GitHub Actions Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 16:00 — with GitHub Actions Inactive
@alafanechere alafanechere temporarily deployed to more-secrets December 13, 2022 16:01 — with GitHub Actions Inactive
@alafanechere alafanechere merged commit 6075284 into master Dec 13, 2022
@alafanechere alafanechere deleted the augustin/server/oauth-span-exception branch December 13, 2022 16:37
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alafanechere @jdpgrailsdev @octavia-squidington-iv