Set breaking change to false when connection is fixed #20315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
alovew
requested review from
benmoriceau,
gosusnp,
colesnodgrass and
jdpgrailsdev
benmoriceau
reviewed
Dec 9, 2022
| @@ -654,6 +654,11 @@ protected static ConnectionUpdate toConnectionPatch(final WebBackendConnectionUp | |||
| final List<UUID> finalOperationIds) { | |||
| final ConnectionUpdate connectionPatch = new ConnectionUpdate(); | |||
|
|
|||
| if (webBackendConnectionPatch.getSyncCatalog() != null) { | |||
| // the user has updated their sync catalog, so there is no breaking change | |||
There was a problem hiding this comment.
Should we check that all the change are now not breaking?
There was a problem hiding this comment.
this was considered in the tech design but it requires getting the source schema and calculating a diff again. what do you think?
There was a problem hiding this comment.
this is a simpler way of doing it based on FE validations (they can't update an invalid sync catalog), but maybe it's better for us to re-validate here too
There was a problem hiding this comment.
just realized the env variable won't work if we do this, since we're marking connections as broken even in the absence of the env variable. so I'll have to update to fetch the most recent actor catalog and do a diff to check whether it's broken
octavia-squidington-iv
removed
area/server
area/platform
alovew
force-pushed
the
anne/update-endpoing-fixes-broken-connection
branch
from
3feaca1
to
d45e124
Compare
octavia-squidington-iv
added
area/platform
benmoriceau
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users update their connection's sync catalog after there is a breaking schema change, the breaking_change field should be set to false