🪟 🎉 Re-validate connection edit form after schema refresh to highlight any missing keys or cursors #20327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
teallarson
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Looks good. I suppose at this point the form is "touched". We could also choose to just run validation directly. I support this way of doing things though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change ensures that the form highlights any areas that may have gone missing after the schema was refreshed. For example, the primary key and the cursor.
How
This uses a hook component that sets the form as touch and revalidates after the schema has been refreshed. Sets the catalog to touched so that the changes are immediately cancelable.