Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document IntelliJ exclusion manual workaround #20363

Merged
merged 1 commit into from Dec 16, 2022

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Dec 12, 2022

What

The steps for excluding files sometimes does not work in IntelliJ. The reason is not clear but @erohmensing found a manual workaround that users can leverage to alleviate the issue.

How

Improving documentation to share the information on https://docs.airbyte.com/contributing-to-airbyte/monorepo-python-development/#excluding-files-from-venv

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Dec 12, 2022
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helpful in any case!

Maybe @girarda has an idea what changed? Looks like he is the one who wrote those instructions

@maxi297
Copy link
Contributor Author

maxi297 commented Dec 16, 2022

Helpful in any case!

Maybe @girarda has an idea what changed? Looks like he is the one who wrote those instructions

Alexandre doesn't have this insights unfortunately. Let's merge and if we get more information on this, let's update the documentation.

@maxi297 maxi297 merged commit 6c807a4 into master Dec 16, 2022
@maxi297 maxi297 deleted the intellij-file-exclusion-workaround branch December 16, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants