Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃獰 馃帹 Fix endOfLine formatting with prettier #20370

Merged
merged 2 commits into from Dec 12, 2022

Conversation

josephkmh
Copy link
Contributor

@josephkmh josephkmh commented Dec 12, 2022

What

There are a few files that do not appear to have been run through prettier, or at least were formatted with different rules. I noticed this when they showed up in a diff in an unrelated PR.

image

This PR fixes the formatting of these three files and adds an explicit endOfLine rule to our .prettierrc.js config file.

馃毃 User Impact 馃毃

None!

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 12, 2022
@josephkmh josephkmh marked this pull request as ready for review December 12, 2022 15:52
@josephkmh josephkmh requested a review from a team as a code owner December 12, 2022 15:52
@josephkmh josephkmh changed the title 馃獰 馃帹 Fix formatting with prettier 馃獰 馃帹 Fix endOfLine formatting with prettier Dec 12, 2022
Copy link
Contributor

@matter-q matter-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants