Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR builds run diff check after formatting #20373

Merged
merged 1 commit into from
Dec 12, 2022
Merged

PR builds run diff check after formatting #20373

merged 1 commit into from
Dec 12, 2022

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Dec 12, 2022

Make formatting changes fail faster in the build-connectors-base pr check action. platform-build already does this.

@edgao edgao temporarily deployed to more-secrets December 12, 2022 16:54 — with GitHub Actions Inactive
@edgao edgao temporarily deployed to more-secrets December 12, 2022 16:55 — with GitHub Actions Inactive
supertopher
supertopher approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@supertopher supertopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much love for more clear action names. thanks for the add Ed

fail fast!

@edgao edgao merged commit 529b589 into master Dec 12, 2022
@edgao edgao deleted the edgao/formatting_fails_faster branch December 12, 2022 17:03
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supertopher supertopher supertopher approved these changes

@c-p-b c-p-b Awaiting requested review from c-p-b

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edgao @supertopher