Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃獰 馃帹 Make TextInputContainer styles match other input styles #20397

Merged
merged 1 commit into from Dec 15, 2022

Conversation

lmossman
Copy link
Contributor

@lmossman lmossman commented Dec 12, 2022

What

Resolves #20394

The TextInputContainer styles were not in sync with the styles of our other input components. This PR brings them in line.

E.g. before:
Screen Shot 2022-12-12 at 2 20 45 PM

after:
Screen Shot 2022-12-12 at 2 20 51 PM

Recommended reading order

  1. x.java
  2. y.python

馃毃 User Impact 馃毃

Consistent input styles

@lmossman lmossman marked this pull request as ready for review December 12, 2022 22:22
@lmossman lmossman requested a review from a team as a code owner December 12, 2022 22:22
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Dec 12, 2022
@lmossman lmossman changed the title make TextInputContainer styles match other input styles 馃獰 馃帹 Make TextInputContainer styles match other input styles Dec 12, 2022
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM, seems to be aligned in all situations now:
Screenshot 2022-12-13 at 10 15 22
Screenshot 2022-12-13 at 10 19 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector form: Multiline secret field styles don't match other fields
3 participants