Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Source Freshdesk: Fix schema types #20416

Merged
merged 11 commits into from
Jan 6, 2023
Merged

🐛Source Freshdesk: Fix schema types #20416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0583bc7
Fix schema types
lazebnyi Dec 13, 2022
c94e3cd
Updated version
lazebnyi Dec 20, 2022
ba320a8
Updated acceptance tests
lazebnyi Jan 5, 2023
7cf066d
Master merged to branch
lazebnyi Jan 5, 2023
15f1765
auto-bump connector version
octavia-squidington-iii Jan 5, 2023
4965344
Merge branch 'master' into lazebnyi/fix-source-freshdesk-schema-type
lazebnyi Jan 5, 2023
a633bd6
Merge branch 'master' into lazebnyi/fix-source-freshdesk-schema-type
lazebnyi Jan 5, 2023
1c046d2
Merge branch 'master' into lazebnyi/fix-source-freshdesk-schema-type
lazebnyi Jan 5, 2023
ec60853
Merge branch 'master' into lazebnyi/fix-source-freshdesk-schema-type
lazebnyi Jan 5, 2023
53db75f
Merge branch 'master' into lazebnyi/fix-source-freshdesk-schema-type
lazebnyi Jan 5, 2023
43ca085
Merge branch 'master' into lazebnyi/fix-source-freshdesk-schema-type
lazebnyi Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@
- name: Freshdesk
sourceDefinitionId: ec4b9503-13cb-48ab-a4ab-6ade4be46567
dockerRepository: airbyte/source-freshdesk
dockerImageTag: 1.0.0
dockerImageTag: 2.0.0
documentationUrl: https://docs.airbyte.com/integrations/sources/freshdesk
icon: freshdesk.svg
sourceType: api
Expand Down
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4386,7 +4386,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-freshdesk:1.0.0"
- dockerImage: "airbyte/source-freshdesk:2.0.0"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/freshdesk"
connectionSpecification:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-freshdesk/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_freshdesk ./source_freshdesk
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=1.0.0
LABEL io.airbyte.version=2.0.0
LABEL io.airbyte.name=airbyte/source-freshdesk
10 changes: 9 additions & 1 deletion airbyte-integrations/connectors/source-freshdesk/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,21 @@ acceptance_tests:
- config_path: "secrets/config.json"
# please remove the backward_capability checks bypass, once updated to the newer version
backward_compatibility_tests_config:
disable_for_version: "0.3.8"
disable_for_version: "1.0.0"
basic_read:
tests:
- config_path: "secrets/config.json"
expect_records:
path: "integration_tests/expected_records.jsonl"
extra_fields: no
exact_order: no
extra_records: yes
timeout_seconds: 600
empty_streams:
- name: skills
bypass_reason: "no records"
- name: products
bypass_reason: "no records"
incremental:
tests:
- config_path: "secrets/config.json"
Expand Down
245 changes: 132 additions & 113 deletions airbyte-integrations/connectors/source-freshdesk/integration_tests/expected_records.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-freshdesk/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from setuptools import find_packages, setup

MAIN_REQUIREMENTS = [
"airbyte-cdk~=0.2",
"airbyte-cdk",
"backoff==1.10.0",
"requests==2.25.1",
"pendulum==2.1.2",
Expand Down
25 changes: 20 additions & 5 deletions airbyte-integrations/connectors/source-freshdesk/source_freshdesk/schemas/sla_policies.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,10 @@
"type": ["null", "integer"]
},
"agent_ids": {
"type": ["null", "integer"]
"type": ["null", "array"],
"items": {
"type": ["null", "integer"]
}
}
}
},
Expand All @@ -152,7 +155,10 @@
"type": ["null", "integer"]
},
"agent_ids": {
"type": ["null", "integer"]
"type": ["null", "array"],
"items": {
"type": ["null", "integer"]
}
}
}
},
Expand All @@ -163,7 +169,10 @@
"type": ["null", "integer"]
},
"agent_ids": {
"type": ["null", "integer"]
"type": ["null", "array"],
"items": {
"type": ["null", "integer"]
}
}
}
},
Expand All @@ -174,7 +183,10 @@
"type": ["null", "integer"]
},
"agent_ids": {
"type": ["null", "integer"]
"type": ["null", "array"],
"items": {
"type": ["null", "integer"]
}
}
}
},
Expand All @@ -185,7 +197,10 @@
"type": ["null", "integer"]
},
"agent_ids": {
"type": ["null", "integer"]
"type": ["null", "array"],
"items": {
"type": ["null", "integer"]
}
}
}
}
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/freshdesk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ The Freshdesk connector should not run into Freshdesk API limitations under norm

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:--------------------------------------------------------------------------------------|
| 2.0.0 | 2022-12-20 | [20416](https://github.com/airbytehq/airbyte/pull/20416) | Fix `SlaPolicies` stream schema |
| 1.0.0 | 2022-11-16 | [19496](https://github.com/airbytehq/airbyte/pull/19496) | Fix `Contacts` stream schema |
| 0.3.8 | 2022-11-11 | [19349](https://github.com/airbytehq/airbyte/pull/19349) | Do not rely on response.json() when deciding to retry a request |
| 0.3.7 | 2022-11-03 | [18397](https://github.com/airbytehq/airbyte/pull/18397) | Fix base url for v2 API. |
Expand Down