🐛 Python CDK: fix StopIteration error for check_availability
#20429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/publish-cdk dry-run=true
|
bazarnov
requested review from
erohmensing,
brianjlai,
davydov-d,
grubberr and
girarda
grubberr
reviewed
Dec 13, 2022
erohmensing
approved these changes
Dec 13, 2022
grubberr
approved these changes
Dec 13, 2022
roman-yermilov-gl
approved these changes
Dec 13, 2022
|
/publish-cdk dry-run=false
|
erohmensing
added a commit
that referenced
this pull request
Dec 15, 2022
…hanges (#20523) * Revert "source-github: move known error handling to GithubAvailabilityStrategy (#19978)" This reverts commit f97db17. * Revert "🐛 Python CDK: fix `StopIteration` error for `check_availability` (#20429)" This reverts commit 4e9b014. * Revert "CDK: `AbstractSource.read()` skips syncing stream if its unavailable (add `AvailabilityStrategy` concept) (#19977)" This reverts commit 55a3288. * Restore changelog entries * bump CDK version * Bump Github version * Re-add removed dependencies * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing
pushed a commit
that referenced
this pull request
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixed missing handling of
StopIterationafter: #19977How
StopIterationerror for empty streams