Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Jira: added unit tests #20525

Merged
merged 90 commits into from Dec 16, 2022
Merged

Source Jira: added unit tests #20525

merged 90 commits into from Dec 16, 2022

Conversation

darynaishchenko
Copy link
Collaborator

NOTE: merge after #20128

@grubberr
bump 0.3.1
1f8c8fa 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/9218-source-jira
9887611
@grubberr
skip requests.codes.NOT_FOUND
d6868c3 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
jira.md updated
47b0541 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
api 2 -> 3
e7d72f5 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/9218-source-jira
96d02a4
@grubberr
api_v1 added
cb11767 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
jql_compare_date moved to IncrementalJiraStream base class
e7aeb6a 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
create IssueFields, Projects in constructor
2735b4f 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/9218-source-jira
5f9704d
@grubberr
_validate_and_transform added
d7b8bf6 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/9218-source-jira
d5c8914
@grubberr
re-implement stream issues
8ebad51 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
fix start_date typing
7834dea 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Boards improved
d888094 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
revert stream Issues work w/o slices
a18eefa 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
issue_comments improved
ea97c79 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
remove redundant primary_key
3b06328 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
improved BoardIssues
c839fce 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Epics added
ce152fa 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
IssueWorklogs refactored
e60cc01 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Sprints refactored
073ef02 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
SprintIssues refactored
9ee74d7 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
move get_updated_state to incremental base class
cf1ab2c 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
move jql_compare_date to incremental base class
5f267f3 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
extract read_records to base incremental class
85f9df1 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Merge branch 'master' into grubberr/9218-source-jira
53c5fc1
@grubberr
rename parse_response_root -> extract_field
a5e4521 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
ApplicationRoles, Avatars - refactored
343dde7 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Projects refactored
bb76891 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
grubberr and others added 4 commits December 15, 2022 12:46
@grubberr
"airbyte-cdk~=0.14"
cd89cd4 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
add more streams to docs
a1a22da 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
extract incremental streams
fb55927 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@darynaishchenko
added unit test for source-jira
f24da68
@octavia-squidington-iv octavia-squidington-iv added connectors/source/jira area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 15, 2022
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Dec 15, 2022 •
edited by github-actions bot

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3706374154
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3706374154
🐛 https://gradle.com/s/kwjqekf75gk5u

Build Failed

Test summary info:

Could not find result summary

@darynaishchenko darynaishchenko marked this pull request as draft December 15, 2022 17:17
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Dec 15, 2022 •
edited by github-actions bot

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3708633932
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3708633932
🐛 https://gradle.com/s/zcs3pe55yahxy

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream issue...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:370: Backward compatibility tests are disabled for version 0.3.0.
============= 1 failed, 29 passed, 1 skipped in 366.48s (0:06:06) ==============

@darynaishchenko darynaishchenko self-assigned this Dec 15, 2022
@darynaishchenko darynaishchenko marked this pull request as ready for review December 15, 2022 23:17
@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Dec 16, 2022 •
edited by github-actions bot

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3712286299
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3712286299
🐛 https://gradle.com/s/6xkcxymmqjfwg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream issue...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:386: Backward compatibility tests are disabled for version 0.3.0.
============= 1 failed, 29 passed, 1 skipped in 362.43s (0:06:02) ==============

@darynaishchenko
Copy link
Collaborator Author

darynaishchenko commented Dec 16, 2022 •
edited by github-actions bot

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3713385692
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3713385692
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_jira/utils.py         21      0   100%
source_jira/__init__.py       2      0   100%
source_jira/source.py        41      2    95%
source_jira/streams.py      632     66    90%
---------------------------------------------
TOTAL                       696     68    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:386: Backward compatibility tests are disabled for version 0.3.0.
================== 30 passed, 1 skipped in 387.38s (0:06:27) ===================

@grubberr
Merge branch 'master' into daryna/jira/unittests
34eb721 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@octavia-squidington-iv octavia-squidington-iv removed the area/documentation Improvements or additions to documentation label Dec 16, 2022
@grubberr
Copy link
Contributor

grubberr commented Dec 16, 2022 •
edited by github-actions bot

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3715673513
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/3715673513
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_jira/utils.py         21      0   100%
source_jira/__init__.py       2      0   100%
source_jira/source.py        41      2    95%
source_jira/streams.py      632     66    90%
---------------------------------------------
TOTAL                       696     68    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 29 passed, 2 skipped in 373.22s (0:06:13) ===================

@grubberr grubberr merged commit 7ae05b1 into master Dec 16, 2022
@grubberr grubberr deleted the daryna/jira/unittests branch December 16, 2022 19:05
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grubberr grubberr grubberr approved these changes

@davydov-d davydov-d Awaiting requested review from davydov-d

Assignees

@darynaishchenko darynaishchenko

Labels
area/connectors Connector related issues connectors/source/jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@darynaishchenko @grubberr @octavia-squidington-iv