Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃獰 馃悰 Fix JobService for jobs without attempts #20527

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Dec 15, 2022

What

There are sometimes jobs that don't have any attempts (yet). When we load them this code broke, since we tried to access attempt.endedAt on undefined now. Fixed this to make sure we have any attempts actually before trying to get the last one.

Since we can't fetch any logs in this case, we're actually just showing now a simple error message when the job is expanded:

screenshot-20221215-202147

The code below that line already handled the case when lastAttemptEndTimestamp is undefined.

@timroes timroes added type/bug Something isn't working area/frontend Related to the Airbyte webapp ui/logs labels Dec 15, 2022
@timroes timroes requested a review from a team as a code owner December 15, 2022 17:39
@octavia-squidington-iv octavia-squidington-iv added the area/platform issues related to the platform label Dec 15, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the log just empty in this scenario?

@timroes
Copy link
Collaborator Author

timroes commented Dec 15, 2022

We can't even load the log in this case, thus I think this implementation won't solve it alone. I'm waiting for feedback from platform workflow to understand how we can end up in scenarios without attempts at all.

@timroes
Copy link
Collaborator Author

timroes commented Dec 15, 2022

This is what you'd be seeing atm:

screenshot-20221215-195544

Copy link
Contributor

@lmossman lmossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not test locally

Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@timroes timroes merged commit 2971ab1 into master Dec 15, 2022
@timroes timroes deleted the tim/fix-job-service branch December 15, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants