Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bigcommerce CDK dependency #20540

Merged
merged 3 commits into from Dec 15, 2022
Merged

Update bigcommerce CDK dependency #20540

merged 3 commits into from Dec 15, 2022

Conversation

erohmensing
Copy link
Contributor

separating out from other pr

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bigcommerce labels Dec 15, 2022
@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

/test connector=connectors/source-bigcommerce

🕑 connectors/source-bigcommerce https://github.com/airbytehq/airbyte/actions/runs/3707417474
❌ connectors/source-bigcommerce https://github.com/airbytehq/airbyte/actions/runs/3707417474
🐛 https://gradle.com/s/g2tfmwx2wjr6s

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
============ 1 failed, 28 passed, 2 skipped, 31 warnings in 44.87s =============

@erohmensing
Copy link
Contributor Author

Not sure what's going on here. Asked GL, going to see if this test would succeed if i checkout master before the PR to revert the CDK - though I doubt it because I don't think that was in when they ran on the other PR

@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

Can reproduce the failure locally on latest master and on the commit pre-revert: 9cc3005.

@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

Seems to also fail on 25b0e7ae, which is the commit where the bigcommerce changes were merged in.

@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

According to this comment it seems the failure is known about and currently failing, so I'll ignore it and move forward with publishing. The last time it was published was without running tests. Will follow up with @sajarin

@erohmensing
Copy link
Contributor Author

erohmensing commented Dec 15, 2022

/publish connector=connectors/source-bigcommerce run-tests=false

🕑 Publishing the following connectors:
connectors/source-bigcommerce
https://github.com/airbytehq/airbyte/actions/runs/3708106535


Connector Did it publish? Were definitions generated?
connectors/source-bigcommerce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 15, 2022 21:46 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 15, 2022 21:46 — with GitHub Actions Inactive
@erohmensing erohmensing merged commit bc5b72d into master Dec 15, 2022
@erohmensing erohmensing deleted the ella/fix-bigcommerce branch December 15, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bigcommerce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants