airbyte-server: tag span of additional OAuth routes #20610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iv
added
area/platform
pedroslopez
requested changes
Dec 16, 2022
airbyte-server/src/main/java/io/airbyte/server/handlers/OAuthHandler.java
Outdated
Show resolved
Hide resolved
pedroslopez
reviewed
Dec 16, 2022
Comment on lines
+167
to
+168
| final Map<String, Object> traceTags = Map.of(WORKSPACE_ID_KEY, completeSourceOauthRequest.getWorkspaceId(), SOURCE_DEFINITION_ID_KEY, | ||
| completeSourceOauthRequest.getSourceDefinitionId()); |
There was a problem hiding this comment.
should we have some sort of helper like getOAuthTraceTags or getDestinationTraceTags to make sure they're consistent?
There was a problem hiding this comment.
I'll definitely consider more helper if we trace more things in the future 😄
pedroslopez
approved these changes
Dec 16, 2022
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
temporarily deployed
to
more-secrets
GitHub Actions
Inactive
alafanechere
deleted the
augustin/airbyte-server/trace-oauth-error-on-destinations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I forgot to add tags from additional OAuth routes after this initial PR.
How
Tag the root span with definition and workspace id on
complete_oauth+get_consent_urlfor sources and destinations.