Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Mailchimp: fix the way request params are built #20720

Closed
wants to merge 4 commits into from
Closed

Source Mailchimp: fix the way request params are built #20720

wants to merge 4 commits into from

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1058

How

  • Do not use state as a source for request parameters. Use stream slices instead
  • Set test strictness level to high

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailchimp labels Dec 20, 2022
@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 20, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/3741894825

@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 20, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/3741991655
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/3741991655
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        46      1    98%
source_mailchimp/streams.py      117      7    94%
--------------------------------------------------
TOTAL                            165      8    95%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [3] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
======================== 53 passed, 3 skipped in 50.03s ========================

@davydov-d davydov-d requested a review from a team December 20, 2022 15:57
@davydov-d davydov-d mentioned this pull request Dec 20, 2022
Closed
@davydov-d
Copy link
Collaborator Author

davydov-d commented Dec 20, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mailchimp

🕑 connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/3742296887
✅ connectors/source-mailchimp https://github.com/airbytehq/airbyte/actions/runs/3742296887
Python tests coverage:

Name                           Stmts   Miss  Cover
--------------------------------------------------
source_mailchimp/__init__.py       2      0   100%
source_mailchimp/source.py        46      1    98%
source_mailchimp/streams.py      117      7    94%
--------------------------------------------------
TOTAL                            165      8    95%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [3] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
======================== 53 passed, 3 skipped in 58.68s ========================

@evantahler
Copy link
Contributor

@davydov-d I'm going to delete this branch and close this PR. I'll be asking github to scrub the history of this PR and branch as well to remove expected_records from being publicly available.

Please re-create this PR, but squash your commits to only have the latest version (without expected_records)

@evantahler evantahler closed this Dec 21, 2022
@evantahler evantahler deleted the ddavydov/#1058-source-mailchimp-stream-state-issue branch December 21, 2022 17:00
@evantahler
Copy link
Contributor

@davydov-d Thanks for making #20726 to get a sandbox account. In the mean time, I think it's OK to skip the tests which need expected_records to close the On Call issue.

@davydov-d
Copy link
Collaborator Author

@evantahler great, I'm on my way of re-creating the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycherniaiev ycherniaiev ycherniaiev left review comments

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

@roman-yermilov-gl roman-yermilov-gl Awaiting requested review from roman-yermilov-gl

@alafanechere alafanechere Awaiting requested review from alafanechere

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailchimp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davydov-d @evantahler @alafanechere @ycherniaiev @octavia-squidington-iv