Source google ads: add more logs #20755

davydov-d · 2022-12-21T13:47:55Z

What

#20219

How

add more logs
set test strictness level to high

davydov-d · 2022-12-21T13:49:26Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3749859155
❌ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3749859155
🐛 https://gradle.com/s/dp4scsj4rckeo

Build Failed

Test summary info:

Could not find result summary

davydov-d · 2022-12-21T14:05:44Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3749980642

…d-logging

davydov-d · 2022-12-21T19:19:11Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3752188816
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3752188816
Python tests coverage:

Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/streams.py                 175      8    95%
source_google_ads/source.py                   86      5    94%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               68     12    82%
--------------------------------------------------------------
TOTAL                                        424     31    93%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1603    336    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 29 passed, 2 skipped in 1002.05s (0:16:42) ==================

sherifnada

one blocking question but otherwise lgtm

airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py

…d-logging

davydov-d · 2023-01-10T12:26:48Z

/test connector=connectors/source-google-ads

…d-logging

davydov-d · 2023-01-10T13:12:41Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3883672592

davydov-d · 2023-01-10T14:57:39Z

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3884512360
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/3884512360
Python tests coverage:

Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/streams.py                 175      6    97%
source_google_ads/source.py                   86      5    94%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               73     12    84%
--------------------------------------------------------------
TOTAL                                        429     29    93%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   56-63, 68-81, 244
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 29 passed, 2 skipped in 890.48s (0:14:50) ===================

davydov-d · 2023-01-10T15:50:45Z

/publish connector=connectors/source-google-ads

🕑 Publishing the following connectors:
connectors/source-google-ads
https://github.com/airbytehq/airbyte/actions/runs/3884954432

Connector	Did it publish?	Were definitions generated?
connectors/source-google-ads	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* #1148 source google ads: add more logs * #1148 source google ads: upd changelog * #1148 source google ads: flake fix * #1148 source google ads - fix SATs * #1148 source Google Ads: bump version * #1148 source google ads: upd expected records * auto-bump connector version Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

#1148 source google ads: add more logs

12eb739

octavia-squidington-iv added connectors/source/google-ads area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Dec 21, 2022

#1148 source google ads: upd changelog

635aa27

davydov-d requested review from lazebnyi and roman-yermilov-gl December 21, 2022 13:49

davydov-d linked an issue Dec 21, 2022 that may be closed by this pull request

[google-ads] Improve logging to identify why syncs are getting stuck #20219

Closed

#1148 source google ads: flake fix

609e4df

davydov-d added 2 commits December 21, 2022 21:15

#1148 source google ads - fix SATs

b37ba50

Merge branch 'master' into ddavydov/#1148-oncall-source-google-ads-ad…

cd65145

…d-logging

davydov-d requested review from a team December 21, 2022 19:49

sherifnada suggested changes Dec 21, 2022

View reviewed changes

airbyte-integrations/connectors/source-google-ads/source_google_ads/streams.py Show resolved Hide resolved

davydov-d requested a review from sherifnada December 23, 2022 09:26

lazebnyi approved these changes Dec 23, 2022

View reviewed changes

sherifnada approved these changes Dec 24, 2022

View reviewed changes

Merge branch 'master' into ddavydov/#1148-oncall-source-google-ads-ad…

3e22107

…d-logging

davydov-d added 2 commits January 10, 2023 14:28

#1148 source Google Ads: bump version

cce090b

Merge branch 'master' into ddavydov/#1148-oncall-source-google-ads-ad…

1f84f8d

…d-logging

#1148 source google ads: upd expected records

c16f0b5

auto-bump connector version

804f6d7

octavia-squidington-iii temporarily deployed to more-secrets January 10, 2023 16:33 — with GitHub Actions Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 10, 2023 17:23 — with GitHub Actions Inactive

octavia-squidington-iii temporarily deployed to more-secrets January 10, 2023 17:24 — with GitHub Actions Inactive

davydov-d merged commit 58352c9 into master Jan 10, 2023

davydov-d deleted the ddavydov/#1148-oncall-source-google-ads-add-logging branch January 10, 2023 17:59

octavia-squidington-iii mentioned this pull request Jan 12, 2023

Bump Airbyte version from 0.40.27 to 0.40.28 #21359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source google ads: add more logs #20755

Source google ads: add more logs #20755

davydov-d commented Dec 21, 2022

davydov-d commented Dec 21, 2022 •

edited by github-actions bot

davydov-d commented Dec 21, 2022 •

edited by github-actions bot

davydov-d commented Dec 21, 2022 •

edited by github-actions bot

sherifnada left a comment

davydov-d commented Jan 10, 2023

davydov-d commented Jan 10, 2023 •

edited by github-actions bot

davydov-d commented Jan 10, 2023 •

edited by github-actions bot

davydov-d commented Jan 10, 2023 •

edited by github-actions bot

Source google ads: add more logs #20755

Source google ads: add more logs #20755

Conversation

davydov-d commented Dec 21, 2022

What

How

davydov-d commented Dec 21, 2022 • edited by github-actions bot

Build Failed

davydov-d commented Dec 21, 2022 • edited by github-actions bot

davydov-d commented Dec 21, 2022 • edited by github-actions bot

Build Passed

sherifnada left a comment

Choose a reason for hiding this comment

davydov-d commented Jan 10, 2023

davydov-d commented Jan 10, 2023 • edited by github-actions bot

davydov-d commented Jan 10, 2023 • edited by github-actions bot

Build Passed

davydov-d commented Jan 10, 2023 • edited by github-actions bot

davydov-d commented Dec 21, 2022 •

edited by github-actions bot

davydov-d commented Dec 21, 2022 •

edited by github-actions bot

davydov-d commented Dec 21, 2022 •

edited by github-actions bot

davydov-d commented Jan 10, 2023 •

edited by github-actions bot

davydov-d commented Jan 10, 2023 •

edited by github-actions bot

davydov-d commented Jan 10, 2023 •

edited by github-actions bot