Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make connector ops CODEOWNERS of oauth code #20837

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Make connector ops CODEOWNERS of oauth code #20837

merged 3 commits into from
Dec 22, 2022

Conversation

sherifnada
Copy link
Contributor

What

This PR updates code to match reality.

@sherifnada sherifnada marked this pull request as ready for review December 22, 2022 18:53
@sherifnada sherifnada requested review from a team and evantahler December 22, 2022 18:54
@sherifnada sherifnada temporarily deployed to more-secrets December 22, 2022 18:55 — with GitHub Actions Inactive
@sherifnada sherifnada temporarily deployed to more-secrets December 22, 2022 18:56 — with GitHub Actions Inactive
pedroslopez
pedroslopez approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@pedroslopez pedroslopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

.github/CODEOWNERS Outdated Show resolved Hide resolved
@sherifnada @pedroslopez
Update .github/CODEOWNERS
7189642 
Co-authored-by: Pedro S. Lopez <pedroslopez@me.com>
evantahler
evantahler approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think ideally Connector Operations owns oAuth. I don't think we are fully able to be self-sufficient yet, but this is the goal.

@sherifnada sherifnada temporarily deployed to more-secrets December 22, 2022 19:39 — with GitHub Actions Inactive
@sherifnada sherifnada temporarily deployed to more-secrets December 22, 2022 19:39 — with GitHub Actions Inactive
@sherifnada
Copy link
Contributor Author

@evantahler Happy to help on bootstrapping the team's knowledge of oauth & next steps. Will write something up.

@sherifnada sherifnada merged commit c596e6e into master Dec 22, 2022
@sherifnada sherifnada deleted the sherif/make-ops-oauth-codeowners branch December 22, 2022 19:40
@github-actions github-actions bot mentioned this pull request Dec 27, 2022
Merged
This was referenced Jan 6, 2023
Closed
Closed
This was referenced Jan 6, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

@pedroslopez pedroslopez pedroslopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sherifnada @evantahler @pedroslopez