Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟🎉 Connector builder: Substream slicer and cartesian slicer #20861

Merged
merged 114 commits into from
Jan 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
114 commits
Select commit Hold shift + click to select a range
d2ed762
improve some types
Dec 5, 2022
f474a1c
Merge remote-tracking branch 'upstream/master' into chore-improve-con…
Dec 5, 2022
5b0521f
improve further
Dec 5, 2022
af659fd
Merge remote-tracking branch 'upstream/master' into chore-improve-con…
Dec 6, 2022
1cd3bbb
clean up a bit more
Dec 6, 2022
807c436
refactor loading state
Dec 6, 2022
6c76e0f
Merge remote-tracking branch 'upstream/master' into flash1293/connect…
Dec 6, 2022
05c3107
move loading state up
Dec 6, 2022
eee4303
remove isLoading references
Dec 6, 2022
7d6f977
remove unused props and make fetch connector error work
Dec 6, 2022
0fe11f0
remove special component for name
Dec 6, 2022
34d4814
remove top level state for unifinished flows
Dec 6, 2022
67d62c5
Merge remote-tracking branch 'upstream/master' into flash1293/connect…
Dec 6, 2022
afea882
Merge branch 'flash1293/connector-form-name-override' into flash1293/…
Dec 6, 2022
c7e7475
Merge branch 'master' into flash1293/connector-form-loading-state
Dec 6, 2022
cc7f65f
Merge branch 'chore-improve-connector-form-types' into flash1293/conn…
Dec 6, 2022
a1c6cbd
start removing uiwidget
Dec 6, 2022
9be8337
Update airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard…
Dec 6, 2022
37cee8f
Merge remote-tracking branch 'upstream/master' into flash1293/connect…
Dec 6, 2022
5686241
Merge branch 'flash1293/connector-form-loading-state' of github.com:a…
Dec 6, 2022
7b73364
remove undefined option for selected id
Dec 6, 2022
7058d26
Merge branch 'flash1293/connector-form-loading-state' into flash1293/…
Dec 6, 2022
dd7e82a
Merge branch 'flash1293/connector-form-name-override' into flash1293/…
Dec 6, 2022
6d4c7d3
Merge remote-tracking branch 'upstream/master' into flash1293/connect…
Dec 7, 2022
d624792
Merge branch 'flash1293/connector-form-loading-state' into flash1293/…
Dec 7, 2022
36cf941
Merge branch 'flash1293/connector-form-name-override' into flash1293/…
Dec 7, 2022
b7a6322
Merge remote-tracking branch 'upstream/master' into flash1293/connect…
Dec 7, 2022
72b602a
Merge branch 'flash1293/connector-form-loading-state' into flash1293/…
Dec 7, 2022
5e47a4a
Merge branch 'flash1293/connector-form-name-override' into flash1293/…
Dec 7, 2022
6c71028
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 8, 2022
809625f
remove unused prop
Dec 8, 2022
10446eb
Merge branch 'flash1293/connector-form-loading-state' into flash1293/…
Dec 8, 2022
4a7a885
Merge branch 'flash1293/connector-form-name-override' into flash1293/…
Dec 8, 2022
2024b60
Merge branch 'flash1293/connector-form-unifinished-flows' into flash1…
Dec 8, 2022
ee30092
fix types
Dec 8, 2022
d91df38
remove uiwidget state
Dec 8, 2022
93fe558
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 9, 2022
cbc023a
Merge branch 'flash1293/connector-form-name-override' into flash1293/…
Dec 9, 2022
ec54d38
Merge branch 'flash1293/connector-form-unifinished-flows' into flash1…
Dec 9, 2022
47152ea
clean up
Dec 9, 2022
6ec0e10
adjust comment
Dec 9, 2022
1aa7829
handle errors in a nice way
Dec 9, 2022
7b90088
do not respect default on oneOf fields
Dec 9, 2022
fbefbdd
rename to formblock
Dec 9, 2022
6b3e5e2
reduce re-renders
Dec 9, 2022
9aa3f80
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 12, 2022
c765003
Merge branch 'flash1293/connector-form-unifinished-flows' into flash1…
Dec 12, 2022
5cd77ec
pass error to secure inputs
Dec 12, 2022
5dfbc22
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 13, 2022
a6aa741
simplify and improve styling
Dec 13, 2022
95717d2
align top
Dec 13, 2022
40d162d
Merge branch 'flash1293/connector-form-unifinished-flows' into flash1…
Dec 13, 2022
b9384ee
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 13, 2022
582a5f2
code review
Dec 13, 2022
18d6ce8
remove comment
Dec 13, 2022
60c1f1c
Merge branch 'master' into flash1293/connector-form-remove-ui-widget-…
Dec 14, 2022
9cb595d
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 15, 2022
fe74a45
review comments
Dec 15, 2022
5c00ad0
rename file
Dec 15, 2022
bd0dffc
be strict about boolean values
Dec 15, 2022
1ff8c13
add example
Dec 15, 2022
c6ee526
track form error in error boundary
Dec 15, 2022
05bbd6f
Merge branch 'flash1293/connector-form-remove-ui-widget-state' of git…
Dec 15, 2022
fff4703
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 16, 2022
94ba866
review comments
Dec 16, 2022
97bb0a7
handle unexpected cases better
Dec 16, 2022
633b9b2
Merge branch 'master' into flash1293/connector-form-remove-ui-widget-…
Dec 16, 2022
e47517f
Merge branch 'master' into flash1293/connector-form-remove-ui-widget-…
Dec 16, 2022
e931956
Merge remote-tracking branch 'origin/master' into feature/connector-b…
Dec 16, 2022
6889f66
enrich error with connector id
Dec 19, 2022
7b60406
Merge branch 'flash1293/connector-form-remove-ui-widget-state' into f…
Dec 19, 2022
d5e56eb
Merge branch 'master' into flash1293/connector-form-remove-ui-widget-…
Dec 19, 2022
35a74ba
Merge branch 'flash1293/connector-form-remove-ui-widget-state' into f…
Dec 19, 2022
02c8096
🪟🎉 Add copy stream button (#20577)
Dec 19, 2022
526adfc
rename prop
Dec 20, 2022
7d49233
🪟🎉 Connector builder: Integrate connector form for test input (#20385)
Dec 20, 2022
c5da764
Merge remote-tracking branch 'origin/master' into flash1293/connector…
Dec 20, 2022
6c0bf9d
Merge branch 'flash1293/connector-form-remove-ui-widget-state' into f…
Dec 20, 2022
477977f
use request_body_json instead of request_body_data
lmossman Dec 20, 2022
200cfe7
:window: :art: Move `Add` button into the line of Connector Builder k…
lmossman Dec 21, 2022
c7fd310
🪟🎉 Connector builder: Allow defining inputs (#20431)
Dec 22, 2022
e0e3796
fix merge conflict with dropdown prop being renamed to control
Dec 22, 2022
e23a6d8
[Connector Builder] Add paginator (#20698)
lmossman Dec 22, 2022
610e668
[Connector Builder] Add stream slicer (#20748)
lmossman Dec 22, 2022
e68ff49
debounce form builder values update to reduce load
Dec 22, 2022
9ccf294
Merge branch 'master' into flash1293/connector-form-remove-ui-widget-…
Dec 22, 2022
ae9a229
Merge branch 'flash1293/connector-form-remove-ui-widget-state' into f…
Dec 22, 2022
a9e1d09
🪟🔧 Connector builder: use new lowcode manifest (#20715)
Dec 22, 2022
64a7aeb
add substream slicer
Dec 23, 2022
2910aed
add substream and cartesian slicer
Dec 23, 2022
e4f7bba
debounce validation as well
Dec 27, 2022
16c71ae
Merge branch 'master' into flash1293/connector-form-remove-ui-widget-…
Jan 2, 2023
54c070d
Merge branch 'flash1293/connector-form-remove-ui-widget-state' into f…
Jan 2, 2023
5547924
Merge branch 'feature/connector-builder' into flash1293/substream-car…
Jan 2, 2023
2e20fa6
akways show stream test button in error state if there are errors
Jan 2, 2023
65199d0
fix type of oauth input
Jan 2, 2023
92722e0
Merge branch 'master' into flash1293/connector-form-remove-ui-widget-…
Jan 3, 2023
718c233
Merge branch 'flash1293/connector-form-remove-ui-widget-state' into f…
Jan 3, 2023
9033cfc
Merge branch 'feature/connector-builder' into flash1293/substream-car…
Jan 3, 2023
6a8be0b
Merge remote-tracking branch 'origin/master' into feature/connector-b…
Jan 3, 2023
4af99c5
Merge branch 'feature/connector-builder' into flash1293/substream-car…
Jan 3, 2023
16ce351
add validation schema for add stream form
lmossman Jan 3, 2023
25d6586
validate all views on test click
lmossman Jan 3, 2023
64a5eb9
add type to prevent console warning
lmossman Jan 4, 2023
105a8ac
Merge branch 'feature/connector-builder' into flash1293/substream-car…
Jan 4, 2023
a4a4c43
Merge remote-tracking branch 'origin/master' into flash1293/substream…
Jan 4, 2023
2557fef
Merge remote-tracking branch 'origin/master' into flash1293/substream…
Jan 5, 2023
fd4cb74
do not allow path for substream slicer request option
Jan 5, 2023
fe2968d
do not show request option for substream slicer
Jan 5, 2023
cb6cd49
Merge remote-tracking branch 'origin/master' into flash1293/substream…
Jan 5, 2023
4b9d012
Merge branch 'master' into flash1293/substream-cartesian-slicer
lmossman Jan 5, 2023
a2dc39e
rewrite stream slice field tooltip
lmossman Jan 5, 2023
e961350
Merge branch 'master' into flash1293/substream-cartesian-slicer
lmossman Jan 5, 2023
efb3f66
Merge branch 'master' into flash1293/substream-cartesian-slicer
lmossman Jan 5, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 33 additions & 8 deletions airbyte-webapp/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions airbyte-webapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"@sentry/tracing": "^6.19.6",
"@tanstack/react-table": "^8.7.0",
"@types/segment-analytics": "^0.0.34",
"@types/uuid": "^9.0.0",
"classnames": "^2.3.1",
"dayjs": "^1.11.3",
"firebase": "^9.8.2",
Expand Down Expand Up @@ -80,6 +81,7 @@
"styled-components": "^5.3.5",
"typesafe-actions": "^5.1.0",
"unist-util-visit": "^4.1.0",
"uuid": "^9.0.0",
"yup": "^0.32.11"
},
"devDependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import merge from "lodash/merge";
import { useState } from "react";
import React from "react";
import { FormattedMessage, useIntl } from "react-intl";
import { v4 as uuid } from "uuid";
import * as yup from "yup";

import { Button } from "components/ui/Button";
Expand Down Expand Up @@ -55,6 +56,7 @@ export const AddStreamButton: React.FC<AddStreamButtonProps> = ({ onAddStream, b
...initialValues,
name: values.streamName,
urlPath: values.urlPath,
id: uuid(),
}),
]);
setIsOpen(false);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@use "scss/variables";
@use "scss/colors";

$removeButtonWidth: 20px;

.itemWrapper {
display: flex;
gap: variables.$spacing-md;
}

.itemContainer {
flex-grow: 1;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import { faPlus } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { useField } from "formik";
import React, { ReactElement, useMemo } from "react";
import { FormattedMessage } from "react-intl";

import { Button } from "components/ui/Button";

import styles from "./BuilderList.module.scss";
import { RemoveButton } from "./RemoveButton";

interface BuilderListProps {
children: (props: { buildPath: (path: string) => string }) => ReactElement;
basePath: string;
emptyItem: object;
}

export const BuilderList: React.FC<BuilderListProps> = ({ children, emptyItem, basePath }) => {
const [list, , helpers] = useField<object[]>(basePath);

const buildPathFunctions = useMemo(
() =>
new Array(list.value.length).fill(undefined).map((_value, index) => {
return (path: string) => `${basePath}[${index}]${path !== "" ? "." : ""}${path}`;
}),
[basePath, list.value.length]
);

return (
<>
{buildPathFunctions.map((buildPath, currentItemIndex) => (
<div className={styles.itemWrapper} key={currentItemIndex}>
<div className={styles.itemContainer}>{children({ buildPath })}</div>
<RemoveButton
onClick={() => {
const updatedItems = list.value.filter((_, index) => index !== currentItemIndex);
helpers.setValue(updatedItems);
}}
/>
</div>
))}
<div>
<Button
variant="secondary"
icon={<FontAwesomeIcon icon={faPlus} />}
onClick={() => {
helpers.setValue([...list.value, { ...emptyItem }]);
}}
>
<FormattedMessage id="connectorBuilder.addNewSlicer" />
</Button>
</div>
</>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ interface Option {
default?: object;
}

interface OneOfOption {
export interface OneOfOption {
label: string; // label shown in the dropdown menu
typeValue: string; // value to set on the `type` field for this component - should match the oneOf type definition
default?: object; // default values for the path
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,3 @@ $removeButtonWidth: 20px;
.kvLabel {
color: colors.$grey-400;
}

.removeButton {
border: none;
background-color: transparent;
color: colors.$grey;
cursor: pointer;
padding: 0;
width: $removeButtonWidth;
height: $removeButtonWidth;
font-size: 18px;
transition: variables.$transition;

&:hover {
color: colors.$red;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { faXmark } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
import { useField } from "formik";
import { FormattedMessage } from "react-intl";

Expand All @@ -10,6 +8,7 @@ import { Input } from "components/ui/Input";
import { Text } from "components/ui/Text";

import styles from "./KeyValueListField.module.scss";
import { RemoveButton } from "./RemoveButton";

interface KeyValueInputProps {
keyValue: [string, string];
Expand All @@ -32,9 +31,7 @@ const KeyValueInput: React.FC<KeyValueInputProps> = ({ keyValue, onChange, onRem
</Text>
<Input value={keyValue[1]} onChange={(e) => onChange([keyValue[0], e.target.value])} />
</div>
<button type="button" className={styles.removeButton} onClick={onRemove}>
<FontAwesomeIcon icon={faXmark} size="1x" />
</button>
<RemoveButton onClick={onRemove} />
</div>
);
};
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
@use "scss/variables";
@use "scss/colors";

$removeButtonWidth: 20px;

.removeButton {
border: none;
background-color: transparent;
color: colors.$grey;
cursor: pointer;
padding: 0;
width: $removeButtonWidth;
height: $removeButtonWidth;
font-size: 18px;
transition: variables.$transition;

&:hover {
color: colors.$red;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { faXmark } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";

import styles from "./RemoveButton.module.scss";

export const RemoveButton = ({ onClick }: { onClick: () => void }) => {
return (
<button className={styles.removeButton} onClick={onClick}>
<FontAwesomeIcon icon={faXmark} />
</button>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { useField } from "formik";
import { useMemo } from "react";
import { FormattedMessage } from "react-intl";

import { ControlLabels } from "components/LabeledControl";
import { DropDown } from "components/ui/DropDown";
import { Text } from "components/ui/Text";

import { BuilderStream } from "../types";
import styles from "./BuilderField.module.scss";

interface StreamReferenceFieldProps {
// path to the location in the Connector Manifest schema which should be set by this component
path: string;
label: string;
tooltip?: string;
optional?: boolean;
currentStreamIndex: number;
}

export const StreamReferenceField: React.FC<StreamReferenceFieldProps> = ({
path,
label,
tooltip,
optional,
currentStreamIndex,
...props
}) => {
const [streams] = useField<BuilderStream[]>("streams");
const [field, meta, helpers] = useField(path);
const hasError = !!meta.error && meta.touched;

const options = useMemo(() => {
return streams.value
.filter((_value, index) => index !== currentStreamIndex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To solve the circular dependency case that you called out, maybe we could expand this filter logic to also exclude streams that are descendants of the current stream.

I think this would require keeping track of the whole tree of substream parents in a state somewhere and will definitely add some complexity, so we can do that in a separate PR. Want to create an issue for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good, gonna create an issue for that.

.map((stream) => ({
value: stream.id,
label: stream.name,
}));
}, [currentStreamIndex, streams.value]);

return (
<ControlLabels className={styles.container} label={label} infoTooltipContent={tooltip} optional={optional}>
<DropDown
{...props}
options={options}
onChange={(selected) => selected && helpers.setValue(selected.value)}
value={field.value}
error={hasError}
/>
{hasError && (
<Text className={styles.error}>
<FormattedMessage id={meta.error} />
</Text>
)}
</ControlLabels>
);
};
Loading