Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Redshift: Fix integration tests #20882

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

suhomud
Copy link
Contributor

@suhomud suhomud commented Dec 27, 2022

What

Destination Redshift: Reflection cannot access package private class RedshiftInsertDestinationAcceptanceTest

How

Made RedshiftInsertDestinationAcceptanceTest class public access

Recommended reading order

  1. RedshiftInsertDestinationAcceptanceTest.java

🚨 User Impact 🚨

No impact

@suhomud
Copy link
Contributor Author

suhomud commented Dec 27, 2022

/test connector=connectors/destination-redshift

🕑 connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/3786095396
✅ connectors/destination-redshift https://github.com/airbytehq/airbyte/actions/runs/3786095396
Python tests coverage:

Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
normalization/transform_config/__init__.py                            2      0   100%
normalization/transform_catalog/reserved_keywords.py                 14      0   100%
normalization/transform_catalog/__init__.py                           2      0   100%
normalization/destination_type.py                                    14      0   100%
normalization/__init__.py                                             4      0   100%
normalization/transform_catalog/destination_name_transformer.py     166      8    95%
normalization/transform_catalog/table_name_registry.py              174     34    80%
normalization/transform_config/transform.py                         189     48    75%
normalization/transform_catalog/utils.py                             51     14    73%
normalization/transform_catalog/dbt_macro.py                         22      7    68%
normalization/transform_catalog/catalog_processor.py                147     80    46%
normalization/transform_catalog/transform.py                         61     38    38%
normalization/transform_catalog/stream_processor.py                 595    400    33%
-------------------------------------------------------------------------------------
TOTAL                                                              1441    629    56%

Build Passed

Test summary info:

All Passed

@suhomud suhomud requested a review from ryankfu December 27, 2022 08:12
Copy link
Contributor

@ryankfu ryankfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for those unaware, this addresses a reflection issue when testing Destination Acceptance Test due to changes from #19281

@ryankfu
Copy link
Contributor

ryankfu commented Dec 27, 2022

/approve-and-merge reason=” Fixes destination-redshift acceptance test failures on master. See: https://github.com/airbytehq/airbyte/actions/runs/3783267406 and currently on-call so taking this risk in favor of changes for improving FileBuffer performance"

@octavia-approvington
Copy link
Contributor

A crack team of mammals has made a decision.
imagine a seal of approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants