airbyte worker should be configured with the correct secrets manager based on env vars configured #20997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the bug in the Airbyte worker, where the persistent secret state manager is not initialized correctly or consistently with Airbyte server.
Support for AWS secret manager was added in - #19690.
If environment variables are set to use AWS secret manager, Airbyte server creates the secrets correctly, but the worker crashes with -
How
Describe the solution
Recommended reading order
application.yml
SecretPersistenceBeanFactory.java
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
NO.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Tests
Unit
File change does not seem to have an unit test or maybe I am wrong. Could you point me to the right file?
Integration
File change does not seem to have an integration test or maybe I am wrong. Could you point me to the right file?
Acceptance
Put your acceptance tests output here.