Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the cursors and primary keys to be deselected when the sync mode does not require it #21117

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

mfsiega-airbyte
Copy link
Contributor

What

Allows the cursor field to be deselected if the sync mode is FULL_REFRESH and the primary key to be deselected if the destination sync mode is not DEDUP.

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/server labels Jan 6, 2023
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 6, 2023 18:15 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 6, 2023 18:15 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 6, 2023 19:03 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 6, 2023 19:03 — with GitHub Actions Inactive
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me 👍

@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 9, 2023 15:28 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 9, 2023 15:28 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 9, 2023 16:14 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 9, 2023 16:14 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 9, 2023 16:59 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte temporarily deployed to more-secrets January 9, 2023 16:59 — with GitHub Actions Inactive
@mfsiega-airbyte mfsiega-airbyte merged commit 21b5eab into master Jan 9, 2023
@mfsiega-airbyte mfsiega-airbyte deleted the msiega/column-selection-api-changes branch January 9, 2023 18:03
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants