Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce HTTPS #21182

Merged
merged 2 commits into from Jan 11, 2023
Merged

Enforce HTTPS #21182

merged 2 commits into from Jan 11, 2023

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Jan 10, 2023

What

Remove protocol option from databend spec and enforce HTTPS, so that we can add this connector to Airbyte Cloud

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 10, 2023
@grishick
Copy link
Contributor Author

grishick commented Jan 10, 2023

/test connector=connectors/destination-databend

🕑 connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/3879392923
✅ connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/3879392923
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
destination_databend/client.py           12      0   100%
destination_databend/__init__.py          2      0   100%
destination_databend/destination.py      43      2    95%
destination_databend/writer.py           48      5    90%
---------------------------------------------------------
TOTAL                                   105      7    93%

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor Author

grishick commented Jan 10, 2023

/publish connector=connectors/destination-databend

🕑 Publishing the following connectors:
connectors/destination-databend
https://github.com/airbytehq/airbyte/actions/runs/3887533303


Connector Did it publish? Were definitions generated?
connectors/destination-databend

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick
Copy link
Contributor Author

grishick commented Jan 10, 2023

/publish connector=connectors/destination-databend

🕑 Publishing the following connectors:
connectors/destination-databend
https://github.com/airbytehq/airbyte/actions/runs/3888127878


Connector Did it publish? Were definitions generated?
connectors/destination-databend

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 10, 2023 23:39 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 10, 2023 23:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants