馃獰 馃悰 Fix auto detect schema change backdrop color CSS #21246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnaglick
approved these changes
Jan 11, 2023
| @@ -16,7 +16,7 @@ | |||
| @extend %cover; | |||
|
|
|||
| position: absolute; | |||
| background: linear-gradient(180deg, rgba(colors.$grey-50, 0.5) 0%, colors.$white 92.54%); | |||
| background: linear-gradient(180deg, rgba(248, 248, 250, 50% /* grey-50 50% */) 0%, colors.$white 92.54%); | |||
There was a problem hiding this comment.
Yeah using rgba() with color variables will no longer work. My suggestion is to treat opaque variants of theme colors as their own variables (see e.g. the overlay background color here) or, if they're really one-off colors, to define them inline like here.
In this case I'm not sure which is more appropriate, probably best to define it inline like you did. But basically I would decouple it from grey-50, since it's a different color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes a CSS rule that prevents rendering the background that covers the replication settings when schema changes have been detected.
Caused by #19344
How
rgba(var(--color-name), 50%)is not supported, so the color must be extracted into the RGB values first.