turn off HttpAvailabilityStrategy as default (for now) #21488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girarda
approved these changes
Jan 18, 2023
erohmensing
added a commit
that referenced
this pull request
Jan 18, 2023
…gy default not turned on yet) (#21484) * Restore AvailabilityStrategy * Add test for http availability strategy on empty stream from original bug fix 7c17351 * fix flake errors * Change CheckStream to use availability strategy * Refactor test from bug fix * fix flake errors * Remove extra helper file from cherry-pick * Merge tests for default http availability strategy * turn off HttpAvailabilityStrategy as default (for now) (#21488) * turn off HttpAvailabilityStrategy as default (for now) * Update imports accordingly
erohmensing
added a commit
that referenced
this pull request
Jan 25, 2023
Closed
6 tasks
erohmensing
added a commit
that referenced
this pull request
Jan 26, 2023
This reverts commit 8570f59.
erohmensing
added a commit
that referenced
this pull request
Jan 26, 2023
2 tasks
erohmensing
added a commit
that referenced
this pull request
Feb 1, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the rollout plan, we want to start by introducing the HttpAvailabiltyStrategy into the code without it being the default.
We'll make it default (revert changes from this PR) at the same time as turning it off for GA connectors and problem connectors.