-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🔧 Don't request destination/source definition in <ConnectionInfoCard />
directly, use useConnectionFormService()
instead
#21869
Conversation
…use useConnectionFormService instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is looking good, but noticed one more requirement...
airbyte-webapp/src/components/connection/ConnectionInfoCard/ConnectionInfoCard.tsx
Outdated
Show resolved
Hide resolved
… the top-level source and destination objects instead of the definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally. LGTM
What
Resolves #21661
How
Don't request destination/source definition in
<ConnectionInfoCard />
directly, useuseConnectionFormService()
instead