-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set availabilitystrategy for GA connectors + gitlab with httpstreams explicitly to None
#21888
Closed
Closed
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
8570f59
Restore HttpAvailabilityStrategy as default (revert https://github.co…
erohmensing 8dc7b37
Turn off default for source-gitlab (default won't work for some strea…
erohmensing 9931d65
Turn off default for source-amazon-ads (GA)
erohmensing e72fc6e
Turn off default for source-amplitude (GA)
erohmensing 1cda6dc
Turn off default for source-facebook-marketing (GA)
erohmensing 532d105
Turn off default for source-freshdesk (GA)
erohmensing ced6aae
Turn off default for source-github (GA)
erohmensing 6417cc0
Turn off default for source-google-analytics-v4 (GA)
erohmensing 8434c97
Turn off default for source-google-search-console (GA)
erohmensing ac5afae
Turn off default for source-harvest (GA)
erohmensing 317ada1
Turn off default for source-hubspot (GA)
erohmensing fb1bd65
Turn off default for source-intercom (GA)
erohmensing 959e577
Turn off default for source-iterable (GA)
erohmensing 37eef69
Turn off default for source-klaviyo (GA)
erohmensing c9a4d31
Turn off default for source-linkedin-ads (GA)
erohmensing e061a0c
Turn off default for source-mailchimp (GA)
erohmensing 50d0b0a
Turn off default for source-marketo (GA)
erohmensing 778da43
Turn off default for source-mixpanel (GA)
erohmensing d104579
Turn off default for source-notion (GA)
erohmensing 35b873f
Turn off default for source-paypal-transaction (GA)
erohmensing a3642dd
Turn off default for source-pinterest (GA)
erohmensing 9365731
Turn off default for source-recharge (GA)
erohmensing 24dbdb3
Turn off default for source-salesforce (GA)
erohmensing 5626180
Turn off default for source-sentry (GA)
erohmensing 2a5e88a
Turn off default for source-slack (GA)
erohmensing 1fbf6b7
Turn off default for source-snapchat-marketing (GA)
erohmensing e63bb0e
Turn off default for source-stripe (GA)
erohmensing 2242ee7
Turn off default for source-surveymonkey (GA)
erohmensing 41f8519
Turn off default for source-tiktok-marketing (GA)
erohmensing c3a03f1
Turn off default for source-twilio (GA)
erohmensing 42130a5
Turn off default for source-zendesk-chat (GA)
erohmensing 91c14a7
Turn off default for source-zendesk-support (GA)
erohmensing 4431df6
Turn off default for source-zendesk-talk (GA)
erohmensing 953d7d3
use correct import
erohmensing 4e84e61
run format on sources
erohmensing e0363fd
Merge branch 'master' into enable-availability
erohmensing 4400f70
Update dockerfiles from merge conflict
erohmensing b755e78
Revert "Restore HttpAvailabilityStrategy as default (revert https://g…
erohmensing 10da72a
Add missing changelog for linkedin-ads
erohmensing 03424dd
Fix typo in source slack import
erohmensing 57a56a0
Fix 2 changelog entries with incorrectly bumped versions
erohmensing 6cb453a
Merge branch 'master' into enable-availability
erohmensing d8f1755
Merge branch 'master' into enable-availability
erohmensing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @erohmensing !
Just reviewing for my own understanding
So the gist of this is
availability_strategy
to the old default ofHttpStream
for subclasses ofHttpStream
.Is that all correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!