Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Marketo: set high test strictness level #21947

Merged

Conversation

lazebnyi
Copy link
Collaborator

What

#19055

How

  • Modify full_refresh catalog
  • Modify incremental catalog
  • Add expected records
  • Refactor acceptance test config

@octavia-squidington-iv octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/marketo labels Jan 26, 2023
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 26, 2023

Note: PR has been approved and merged - link. After that it was reverted (link) because it has braking changes and we need communicate with customers before merge it. After Erica approve will be merged.

@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 26, 2023

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4020055726
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4020055726
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_marketo/__init__.py       2      0   100%
source_marketo/utils.py         33      1    97%
source_marketo/source.py       273     30    89%
------------------------------------------------
TOTAL                          308     31    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
================== 30 passed, 1 skipped in 5089.39s (1:24:49) ==================

@lazebnyi
Copy link
Collaborator Author

Hi @erica-airbyte
This PR will be affect all users what use source marketo, because it change schema field data type.
Can you help us to communicate with users and let me know when I can merge it.

@erica-airbyte
Copy link
Contributor

@lazebnyi there is only one customer that is using this connector.

I will reach out to let them know of the changes.

Can we have this go out next Tuesday January 31st?

@erica-airbyte
Copy link
Contributor

@lazebnyi also will the customer need to refresh source schema and reset affected streams?

@lazebnyi
Copy link
Collaborator Author

@erica-airbyte Ok, let's do that in next Tuesday January 31st. Thanks! Yeah, you are right. The customer need to refresh source schema and reset affected streams.

@lazebnyi lazebnyi linked an issue Jan 27, 2023 that may be closed by this pull request
@lazebnyi lazebnyi removed the request for review from artem1205 January 30, 2023 20:55
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Jan 31, 2023

/publish connector=connectors/source-marketo

🕑 Publishing the following connectors:
connectors/source-marketo
https://github.com/airbytehq/airbyte/actions/runs/4049830710


Connector Did it publish? Were definitions generated?
connectors/source-marketo

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2023 03:10 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 31, 2023 03:10 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.51%

@lazebnyi lazebnyi merged commit 92c1a23 into master Jan 31, 2023
@lazebnyi lazebnyi deleted the ddavydov/#19055-source-marketo-high-test-strictness-level branch January 31, 2023 09:14
@erica-airbyte
Copy link
Contributor

@lazebnyi this is going out today correct?

@lazebnyi
Copy link
Collaborator Author

@erica-airbyte yes, it is already deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/marketo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Marketo: enable high test strictness level in SAT
6 participants